Integrated permissions/ownership diff output for etckeeper/bzr
Bug #322327 reported by
Thierry Carrez
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Wishlist
|
Unassigned | ||
bzr (Ubuntu) |
Triaged
|
Wishlist
|
Unassigned | ||
etckeeper (Ubuntu) |
Triaged
|
Wishlist
|
Unassigned |
Bug Description
Binary package hint: etckeeper
Since the VCS doesn't handle full permissions/
To make etckeeper more user-friendly, it would be nice to integrate the ownership/
This can be done at the bzr etckeeper plugin level, by making bzr aware of the changes present in .etckeeper and produce an integrated output.
Changed in etckeeper: | |
importance: | Undecided → Wishlist |
Changed in etckeeper: | |
status: | New → Confirmed |
Changed in bzr: | |
assignee: | nobody → Thierry Carrez (ttx) |
importance: | Undecided → Wishlist |
status: | New → In Progress |
Changed in etckeeper (Ubuntu): | |
status: | Confirmed → Triaged |
Changed in bzr (Ubuntu): | |
status: | New → Confirmed |
status: | Confirmed → Triaged |
tags: | added: check-for-breezy |
To post a comment you must log in.
I think we need to hook in two places:
- InterTree. iter_changes (tree.py:928) ownership change. A hook allowing to arbitrarily yield some entries (given their file_id) would definitely help.
We need to yield file_ids that happen to just have a permissions/
- DiffTree._show_diff (diff.py:867) ownership changes to properties_changed. A hook allowing to do that would be great. The alternative is to use the existing diff_factory system register a DiffPath that would represent the permissions/ ownership change as a "content change". Less intrusive but somehow inexact.
We need to add permissions/
Those shouldn't require any API change. I'll try to do a PoC for them.