Bazaar

  1. Bug #316357
  2. Comment #5

Comment 5 for bug 316357

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 316357] Re: SIGWINCH support for progress bar

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> The associated branch contains a trivial implementation to catch
> SIGWINCH.
>
> I tested it by running 'bzr selftest -s bt.test_http' and this reveals a
> fundamental flaw: catching the signal can interrupt an IO and if the
> code base is not ready to handle that, we can get weird failures.
>
> I don't know if it's worth handling for a cosmetic benefit but people
> can play with it in a plugin if they really want and have valid use
> cases for that.
>
> ** Branch linked: lp:~vila/bzr/316357-SIGWINCH
>

I thought most of our IO cases trapped EINTR. At least, I thought we
tried to do that.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksf4KwACgkQJdeBCYSNAANlCgCgqFvfyLkcDUyTRBwTDT51BKIH
jcAAoKEEhfZl/ZskEG3G6yyAYtQWBIX3
=hLQa
-----END PGP SIGNATURE-----