stacked branches don't use shared repository

[John A Meinel]

While testing stacked branches, I wanted to skip the working-tree creation, so I created a shared repo with --no-trees.

When doing so, it created its own standalone repository, rather than re-using the local one, which also caused it to build a working tree.

I then tried just removing newbranch/.bzr/repository and I started getting failures:

$ time bzr branch stacked/ unstacked --lsprof-file branch_stacked.txt
bzr: ERROR: The branch stacked/ has no revision None.

Which is strange, considering there are 0 pack files in the standalone location. I certainly would have thought that the standard open commands would find the shared location.

[Aaron Bentley (abentley)]

How did you create the stacked branch?

[John A Meinel (jameinel)]

Here is a way to reproduce it:

bzr init-repo --no-trees --1.9 rtest
cd rtest
$ bzr branch --stacked ../../bzr/bzr.dev/
Source format does not support stacking, using format: '1.6'
  Packs 5 (adds stacking support, requires bzr 1.6)

Created new stacked branch referring to file:///C:/Users/jameinel/dev/bzr/bzr.dev/.

$ bzr info bzr.dev/
Standalone tree (format: 1.6)
Location:
  branch root: bzr.dev

Related branches:
  parent branch: C:/Users/jameinel/dev/bzr/bzr.dev
     stacked on: C:/Users/jameinel/dev/bzr/bzr.dev

So at that point it has completely ignored the shared repository (which is 1.9 format), and just created its own standalone repository. Which is also empty:

$ ls bzr.dev/.bzr/repository/packs

# You can't tell, but that returns nothing.

If I then remove that repository I get
$ rm -rf bzr.dev/.bzr/repository
$ bzr info bzr.dev
Repository tree (format: 1.9)
Location:
  shared repository: .
  repository branch: bzr.dev

Related branches:
  parent branch: C:/Users/jameinel/dev/bzr/bzr.dev
     stacked on: C:/Users/jameinel/dev/bzr/bzr.dev

that seems okay. And
$ bzr log bzr.dev --short -r -10..-1
....

Gives a valid result. But branch does not

$ bzr branch bzr.dev test
bzr: ERROR: The branch bzr.dev/ has no revision None.

[John A Meinel (jameinel)]

I just checked, and this still occurs. After doing 'bzr branch --stacked' it even creates a workingtree even though I did 'bzr init-repo --no-trees'.

[Jesse (sbjesse)]

this still happens in bzr.dev (2.2.0dev1 rev 5137 revid: <email address hidden>
)