get_record_stream/ContentFactory should expose compression parents
Bug #300177 reported by
Martin Pool
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
John A Meinel |
Bug Description
In the course of the recent thread about bug 288751 and "avoid creating text deltas spanning repository stack", it was mentioned that get_record_stream and ContentFactory don't expose the compression parents clearly, but this is probably necessary to correctly apply the deltas.
At any rate it should be clearly defined in the interface whether the parents are the same as the compression parents or not, and what their ordering is.
Changed in bzr: | |
assignee: | nobody → jameinel |
importance: | Undecided → High |
status: | New → Confirmed |
To post a comment you must log in.
For instance there is this code in knit.py, which probably should instead be using an explicit compression parent.
# Add any records whose basis parent is now available.
added_ keys = [record.key] index_entries:
index_ entries = buffered_ index_entries[ key]
self. _index. add_records( index_entries)
added_ keys.extend(
[index_ entry[0] for index_entry in index_entries])
del buffered_ index_entries[ key]
while added_keys:
key = added_keys.pop(0)
if key in buffered_