"bzr add" needlessly tells me everything it ignored

[Brad Bollenbach]

I just had an interaction with "bzr add" that I think can be improved.

First:

bradb@oxygen:~/canonical/malone-smallfixes $ bzr st
added:
  lib/canonical/launchpad/doc/bugtarget.txt
modified:
  lib/canonical/launchpad/database/distribution.py
  lib/canonical/launchpad/database/distributionsourcepackage.py
  lib/canonical/launchpad/database/product.py
  lib/canonical/launchpad/interfaces/bug.py
  lib/canonical/launchpad/zcml/distributionsourcepackage.zcml
unknown:
  lib/canonical/launchpad/components/bugtarget.py

Being lazy, I just type "bzr add" to add that one unknown file.

bradb@oxygen:~/canonical/malone-smallfixes $ bzr add
added lib/canonical/launchpad/components/bugtarget.py
ignored 1 file(s) matching "*.orig"
ignored 651 file(s) matching "*.py[oc]"
ignored 1 file(s) matching "*.so"
ignored 5 file(s) matching "./.bzr-shelf*"
ignored 1 file(s) matching "CVS"
ignored 1 file(s) matching "TAGS"
ignored 1 file(s) matching "configs/+config-overrides.zcml"
ignored 1 file(s) matching "launchpad-access.log"
ignored 1 file(s) matching "launchpad.log"
ignored 1 file(s) matching "sourcecode/buildbot"
ignored 1 file(s) matching "sourcecode/bzr"
ignored 1 file(s) matching "sourcecode/cscvs"
ignored 1 file(s) matching "sourcecode/gnarly"
ignored 1 file(s) matching "sourcecode/hct"
ignored 1 file(s) matching "sourcecode/psycopgda"
ignored 1 file(s) matching "sourcecode/pybaz"
ignored 1 file(s) matching "sourcecode/pygettextpo"
ignored 1 file(s) matching "sourcecode/pyme"
ignored 1 file(s) matching "sourcecode/pytz"
ignored 1 file(s) matching "sourcecode/sourcerer"
ignored 1 file(s) matching "sourcecode/sqlobject"
ignored 1 file(s) matching "sourcecode/sqlos"
ignored 1 file(s) matching "sourcecode/zope"
If you wish to add some of these files, please add them by name.
bradb@oxygen:~/canonical/malone-smallfixes $

It would have been easier on my brain if this just said:

bradb@oxygen:~/canonical/malone-smallfixes $ bzr add
added lib/canonical/launchpad/components/bugtarget.py

1 file added.
bradb@oxygen:~/canonical/malone-smallfixes $

If anything, the current "ignored" output should be hidden behind some kind of flag, maybe -v or --show-ignored.

[Wouter van Heyst (larstiq)]

On Fri, Jan 27, 2006 at 06:52:35PM -0000, Brad Bollenbach wrote:
> Public bug reported:
> https://launchpad.net/malone/bugs/29877
>
> Affects: bzr (upstream)
> Severity: Normal
> Priority: (none set)
> Status: Unconfirmed
>
> Description:
> I just had an interaction with "bzr add" that I think can be improved.
>
> First:
>
> bradb@oxygen:~/canonical/malone-smallfixes $ bzr st
> added:
> lib/canonical/launchpad/doc/bugtarget.txt
> modified:
> lib/canonical/launchpad/database/distribution.py
> lib/canonical/launchpad/database/distributionsourcepackage.py
> lib/canonical/launchpad/database/product.py
> lib/canonical/launchpad/interfaces/bug.py
> lib/canonical/launchpad/zcml/distributionsourcepackage.zcml
> unknown:
> lib/canonical/launchpad/components/bugtarget.py
>
> Being lazy, I just type "bzr add" to add that one unknown file.

I like to do that as well.

> bradb@oxygen:~/canonical/malone-smallfixes $ bzr add
> added lib/canonical/launchpad/components/bugtarget.py

<snip ignored files>

> If you wish to add some of these files, please add them by name.
> bradb@oxygen:~/canonical/malone-smallfixes $

Some of these I do not recognise the pattern that ignores them, it looks
like you ignored them yourself? (ie, not a result of default ignores).
The way you describe your workflow, I'm guessing this list of ignores is
presented each time you add a file? I see how that becomes irritating.

> It would have been easier on my brain if this just said:
>
> bradb@oxygen:~/canonical/malone-smallfixes $ bzr add
> added lib/canonical/launchpad/components/bugtarget.py
>
> 1 file added.
> bradb@oxygen:~/canonical/malone-smallfixes $
>
> If anything, the current "ignored" output should be hidden behind some
> kind of flag, maybe -v or --show-ignored.

But then people (especially new users) will be surprised by ignored files.
When the printing of ignored files was introduced a balance was sought
between these two, it took some time to reach the current state. Perhaps
we can do even better.

Wouter van Heyst

[Robey Pointer (robey)]

What if the normal output looked like this?

"""
$ bzr add
added lib/canonical/launchpad/components/bugtarget.py

1 file added.
9764 files ignored.
"""

then -v could go into detail about what was ignored and why.

[James Blackwell (jblack)]

On Fri, Jan 27, 2006 at 06:52:35PM -0000, Brad Bollenbach wrote:
> Public bug reported:
> https://launchpad.net/malone/bugs/29877
>
> Description:
> I just had an interaction with "bzr add" that I think can be improved.
>
> First:
>
> bradb@oxygen:~/canonical/malone-smallfixes $ bzr st
> [...]
> unknown:
> lib/canonical/launchpad/components/bugtarget.py
>
> Being lazy, I just type "bzr add" to add that one unknown file.
>
> bradb@oxygen:~/canonical/malone-smallfixes $ bzr add
> added lib/canonical/launchpad/components/bugtarget.py
> ignored 1 file(s) matching "*.orig"
> ignored 651 file(s) matching "*.py[oc]"
[_long_ list here]
> ignored 1 file(s) matching "sourcecode/sqlos"
> ignored 1 file(s) matching "sourcecode/zope"
> If you wish to add some of these files, please add them by name.
> bradb@oxygen:~/canonical/malone-smallfixes $
>
> It would have been easier on my brain if this just said:
>
> bradb@oxygen:~/canonical/malone-smallfixes $ bzr add
> added lib/canonical/launchpad/components/bugtarget.py
>
> 1 file added.
> bradb@oxygen:~/canonical/malone-smallfixes $
>
> If anything, the current "ignored" output should be hidden behind some
> kind of flag, maybe -v or --show-ignored.

The intention with printing that is that people tend to get confused when
they run "bzr add <nothing>" and then later find out that a file they
thought was added wasn't. The unadded file doesn't get controlled and
doesn't propogate with standard bzr commands.

Within the light of that concern, what options do you imagine?

--
My home page: <a href="http://jblack.linuxguru.net">James Blackwell</a>
Gnupg 06357400 F-print AAE4 8C76 58DA 5902 761D 247A 8A55 DA73 0635 7400

[Martin Pool (mbp)]

On 1 Feb 2006, James Blackwell <email address hidden> wrote:

> The intention with printing that is that people tend to get confused when
> they run "bzr add <nothing>" and then later find out that a file they
> thought was added wasn't. The unadded file doesn't get controlled and
> doesn't propogate with standard bzr commands.

I think this primarily applies to the initial import. Once people are
up and running, as Brad is, being reminded of all the ignored files is
just a bit annoying.

So perhaps:

  added lib/canonical/launchpad/components/bugtarget.py
  1 file added
  73 ignored files not added

And the help for 'bzr add' could perhaps give a clearer explanation of
how files come to be ignored, and that 'bzr ignored' will tell you about
it.

The current behaviour could be present under --show-ignored.

What do you think?

[Brad Bollenbach (bradb)]

On 1-Feb-06, at 7:54 AM, Martin Pool wrote:

> Public bug report changed:
> https://launchpad.net/malone/bugs/29877
>
> Comment:
> On 1 Feb 2006, James Blackwell <email address hidden> wrote:
>
>> The intention with printing that is that people tend to get
>> confused when
>> they run "bzr add <nothing>" and then later find out that a file they
>> thought was added wasn't. The unadded file doesn't get controlled and
>> doesn't propogate with standard bzr commands.
>
> I think this primarily applies to the initial import. Once people are
> up and running, as Brad is, being reminded of all the ignored files is
> just a bit annoying.
>
> So perhaps:
>
> added lib/canonical/launchpad/components/bugtarget.py
> 1 file added
> 73 ignored files not added
>
> And the help for 'bzr add' could perhaps give a clearer explanation of
> how files come to be ignored, and that 'bzr ignored' will tell you
> about
> it.
>
> The current behaviour could be present under --show-ignored.
>
> What do you think?

+1 to everything you said.

Cheers,

--
Brad Bollenbach

[David Allouche (ddaa)]

That sounds sane.

[Martin Pool (mbp)]

On 9 Mar 2006, at 02:51 , Brad Bollenbach wrote:

> Public bug report changed:
> https://launchpad.net/malone/bugs/29877
>
> Comment:
> On 1-Feb-06, at 7:54 AM, Martin Pool wrote:
>
>> Public bug report changed:
>> https://launchpad.net/malone/bugs/29877
>>
>> Comment:
>> On 1 Feb 2006, James Blackwell <email address hidden> wrote:
>>
>>> The intention with printing that is that people tend to get
>>> confused when
>>> they run "bzr add <nothing>" and then later find out that a file
>>> they
>>> thought was added wasn't. The unadded file doesn't get controlled
>>> and
>>> doesn't propogate with standard bzr commands.
>>
>> I think this primarily applies to the initial import. Once people
>> are
>> up and running, as Brad is, being reminded of all the ignored
>> files is
>> just a bit annoying.
>>
>> So perhaps:
>>
>> added lib/canonical/launchpad/components/bugtarget.py
>> 1 file added
>> 73 ignored files not added
>>
>> And the help for 'bzr add' could perhaps give a clearer
>> explanation of
>> how files come to be ignored, and that 'bzr ignored' will tell you
>> about
>> it.
>>
>> The current behaviour could be present under --show-ignored.
>>
>> What do you think?
>
> +1 to everything you said.

+1 from me too. It should be a simple fix if anyone would like to
try it.

--
Martin Pool

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
|>>The current behaviour could be present under --show-ignored.
|>>
|>>What do you think?
|>
|>+1 to everything you said.
|
|
| +1 from me too. It should be a simple fix if anyone would like to
| try it.

add behaves this way because there is a risk that, otherwise, people
will not know that a file they intended to add was ignored. The point
of it was that it should be something that everyone saw, so they could
see why it was ignoring things. If we're going to hide this under an
option, it won't serve that purpose very well.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFED60Y0F+nu1YWqI0RAqrNAJ9hTww5vqDbxp4xJS8ek58WdTH3BQCeLpiD
TSPIWy0CUJsX8RXSt/M51WE=
=J1S5
-----END PGP SIGNATURE-----

[John A Meinel (jameinel)]

The current bzr.dev just shows what patterns were ignored, without showing all the files.
Seems to match the conclusion reached on this bugtracker. Marking it closed.