Inventory should not provide dictionary interface
Bug #296194 reported by
Martin Pool
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
Low
|
Unassigned | ||
| Breezy |
Fix Released
|
Low
|
Jelmer Vernooij | ||
Bug Description
Inventory provides a collection interface: __len__, __getitem__, __delitem__, __contains__, working on file id. It's not really a dictionary, this puts undue emphasis on file ids, and it'd be better to just provide specific named methods. (In fact in most cases they're already present.)
Related branches
lp:~jelmer/brz/inv-not-dict
- Martin Packman: Approve
-
Diff: 1417 lines (+210/-210)26 files modifiedbreezy/bundle/serializer/v08.py (+1/-1)
breezy/bzr/inventory.py (+38/-38)
breezy/bzr/inventorytree.py (+11/-11)
breezy/bzr/vf_repository.py (+6/-6)
breezy/bzr/workingtree.py (+13/-13)
breezy/bzr/workingtree_4.py (+8/-8)
breezy/merge.py (+4/-4)
breezy/plugins/fastimport/bzr_commit_handler.py (+8/-8)
breezy/plugins/fastimport/revision_store.py (+6/-6)
breezy/plugins/repodebug/file_refs.py (+1/-1)
breezy/tests/per_interrepository/test_fetch.py (+1/-1)
breezy/tests/per_intertree/test_compare.py (+1/-1)
breezy/tests/per_inventory/basics.py (+2/-2)
breezy/tests/per_repository_reference/test_add_inventory.py (+2/-2)
breezy/tests/per_repository_vf/test_add_inventory_by_delta.py (+2/-2)
breezy/tests/per_repository_vf/test_fileid_involved.py (+1/-1)
breezy/tests/per_tree/test_tree.py (+1/-1)
breezy/tests/per_workingtree/test_nested_specifics.py (+1/-1)
breezy/tests/per_workingtree/test_parents.py (+4/-4)
breezy/tests/test_commit.py (+6/-6)
breezy/tests/test_dirstate.py (+1/-1)
breezy/tests/test_inv.py (+72/-72)
breezy/tests/test_revisiontree.py (+1/-1)
breezy/tests/test_transform.py (+1/-1)
breezy/tests/test_xml.py (+17/-17)
breezy/tree.py (+1/-1)
| Changed in bzr: | |
| assignee: | nobody → mbp |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| tags: | added: api inventory |
| Changed in bzr: | |
| assignee: | Martin Pool (mbp) → nobody |
| tags: | added: tech-debt |
| Changed in brz: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| milestone: | none → 3.0.0 |
| Changed in brz: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
