| 2008-11-03 12:11:15 |
Saša Janiška |
bug |
|
|
added bug |
| 2008-11-03 14:43:51 |
John A Meinel |
title |
bzr: ERROR: exceptions.AttributeError: sendall |
bzr fails with python2.6 and https missing sendall |
|
| 2008-11-03 14:48:23 |
John A Meinel |
bzr: status |
New |
Triaged |
|
| 2008-11-03 14:48:23 |
John A Meinel |
bzr: importance |
Undecided |
Medium |
|
| 2008-11-03 14:48:23 |
John A Meinel |
bzr: statusexplanation |
|
So it seems we have a compatibility issue with python2.6.
I don't see a function called "ssl.wrap_socket()" it python2.5 and early. There is socket.ssl(sock)
so perhaps they mean that instead of using:
ssl = socket.ssl(self.sock, self.key_file, self.cert_file)
self.sock = httplib.FakeSocket(self.sock, ssl)
we should be doing
self.sock = socket.ssl(self.sock, self.key_file, self.cert_file)
Anyway, it seems that not only did they deprecate FakeSocket, they also broke it by removing the 'sendall()' function. |
|
| 2008-11-03 19:13:56 |
Vincent Ladeuil |
bzr: assignee |
|
vila |
|
| 2008-11-03 19:13:56 |
Vincent Ladeuil |
bzr: statusexplanation |
So it seems we have a compatibility issue with python2.6.
I don't see a function called "ssl.wrap_socket()" it python2.5 and early. There is socket.ssl(sock)
so perhaps they mean that instead of using:
ssl = socket.ssl(self.sock, self.key_file, self.cert_file)
self.sock = httplib.FakeSocket(self.sock, ssl)
we should be doing
self.sock = socket.ssl(self.sock, self.key_file, self.cert_file)
Anyway, it seems that not only did they deprecate FakeSocket, they also broke it by removing the 'sendall()' function. |
The most amazing is that the test suite didn't catch that :-/
Or may be my python-2.6 built from sources is not up-to-date (I branched from trunk, mau be some divergence occurred since then).
Gour, what linux are you using ?
|
|
| 2008-11-05 07:38:35 |
Vincent Ladeuil |
bzr: status |
Triaged |
In Progress |
|
| 2008-11-05 07:38:35 |
Vincent Ladeuil |
bzr: importance |
Medium |
High |
|
| 2008-11-05 07:38:35 |
Vincent Ladeuil |
bzr: statusexplanation |
The most amazing is that the test suite didn't catch that :-/
Or may be my python-2.6 built from sources is not up-to-date (I branched from trunk, mau be some divergence occurred since then).
Gour, what linux are you using ?
|
|
|
| 2008-11-05 20:57:27 |
Vincent Ladeuil |
bzr: status |
In Progress |
Fix Committed |
|
| 2008-11-05 20:57:27 |
Vincent Ladeuil |
bzr: statusexplanation |
|
A fix is available in the associated branch.
As mentioned in the comments, this bug wasn't caught by the test suite because we lack an https test server.
An https test server needs a certificate, and we want to be able to generate certificates for test purposes, etc.
This is still a work in progress that I can't submit for inclusion in core without enough tests.
And as this bug demonstrated even a single test can't be written without an https server.
Anyway, lp:~vila/bzr/https-test-server from which the fix has been sitting for months (sorry :-/) has enough support to run all the tests usually using an http server against an https server.
So the available fix has been tested again after I merged from bzr.dev. |
|
| 2008-11-07 06:25:03 |
Martin Pool |
bzr: status |
Fix Committed |
Fix Released |
|
| 2008-11-07 06:25:03 |
Martin Pool |
bzr: statusexplanation |
A fix is available in the associated branch.
As mentioned in the comments, this bug wasn't caught by the test suite because we lack an https test server.
An https test server needs a certificate, and we want to be able to generate certificates for test purposes, etc.
This is still a work in progress that I can't submit for inclusion in core without enough tests.
And as this bug demonstrated even a single test can't be written without an https server.
Anyway, lp:~vila/bzr/https-test-server from which the fix has been sitting for months (sorry :-/) has enough support to run all the tests usually using an http server against an https server.
So the available fix has been tested again after I merged from bzr.dev. |
|
|
| 2008-11-07 06:25:03 |
Martin Pool |
bzr: milestone |
|
1.9final |
|
