uncommit should mark revisions as uncommitted

[Adrian Wilkins]

When you uncommit, it leaves a dead head lying around in your repository. These heads clutter the output of the "heads" command.

If uncommit marked the revision it was uncommitting, or kept it in a repo-level list, these heads could be filtered from the output of "heads".

[Jelmer Vernooij (jelmer)]

Isn't the whole point of "bzr heads" to be able to find this sort of revision?

[Robert Collins (lifeless)]

On Thu, 2008-09-18 at 22:33 +0000, Adrian Wilkins wrote:
> Public bug reported:
>
> When you uncommit, it leaves a dead head lying around in your
> repository. These heads clutter the output of the "heads" command.
>
> If uncommit marked the revision it was uncommitting, or kept it in a
> repo-level list, these heads could be filtered from the output of
> "heads".

I think this would be nice; not sure how to make it happen efficiently
etc :P

 status confirmed
 importance wishlist
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Adrian Wilkins (adrian-wilkins)]

> Isn't the whole point of "bzr heads" to be able to find this sort of revision?

It's also there to find the heads of branches you deleted, etc.

Often when you uncommit, it's for trivial things like "I forgot to add a file", or "I didn't want to commit that file as part of this revision", or "I messed up the log comment". Having these heads in your output is probably a sign that you should commit more carefully, but it happens a great deal and it would be nice to be able to ignore them.

My thought on implementation is that a simple line-based "uncommitted-revisions" list in the repository might be a good way of implementing this ; read the list and allow filtering dead revisions that are contained in the list. If you branch to another repo, dead revisions are not copied unless you are taking pains to identify one as the desired tip, so you don't need anything that stores data in the actual revision ; uncommitted revisions you end up resurrecting are no longer dead.

[Jelmer Vernooij (jelmer)]

Perhaps this is something that bzr-tiplog can help with, as it records e.g. why a revision was removed from the branch mainline.

[Martin Pool (mbp)]

On 1 December 2011 07:25, Jelmer Vernooij <email address hidden> wrote:
> Perhaps this is something that bzr-tiplog can help with, as it records
> e.g. why a revision was removed from the branch mainline.

I think that's the way to go.

--
Martin