bzr commit -x doesn't change the --show-diff output (iter_changes does not support excludes)
Bug #268135 reported by
James Westby
This bug affects 6 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
Breezy |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
"bzr commit -x" correctly excludes files from the commit, but the --show-diff
output still includes all of those changes, which can worry the user, and make
it harder to see the parts of the diff that you care about.
This is caused by the workhorse that commit depends on - iter_changes - not supporting excludes.
Related branches
lp:~jelmer/brz/commit-exclude
- Martin Packman: Approve
-
Diff: 138 lines (+70/-5)3 files modifiedbreezy/commit.py (+29/-4)
breezy/tests/test_commit.py (+38/-1)
doc/en/release-notes/brz-3.0.txt (+3/-0)
Changed in bzr: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in bzr: | |
status: | Triaged → Confirmed |
tags: | added: commit |
Changed in brz: | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Jelmer Vernooij (jelmer) |
Changed in brz: | |
status: | Triaged → Fix Released |
milestone: | none → 3.0.0 |
To post a comment you must log in.
On 19/03/10 08:29, Martin Pool wrote:
> ** Tags added: commit
I think the root cause for this is a dupe: show-diff output uses the
diff feature of bzr, and that depends on iter changes and there is abug
open that iter changes doeswn't support excludes.
Cheers,
Rob