backup.bzr directory is world readable
Bug #262450 reported by
James Troup
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Parth Malwankar | ||
2.0 |
Fix Released
|
High
|
Parth Malwankar | ||
2.1 |
Fix Released
|
High
|
Unassigned | ||
2.2 |
Fix Released
|
High
|
Unassigned |
Bug Description
When you 'bzr upgrade' the backup.bzr directory is created world readable. For people who use permissions on the local .bzr as access control this is critically bad. Please don't do that and instead either clone the permissions from .bzr or default to 0700.
Related branches
lp:~parthm/bzr/262450
- Vincent Ladeuil: Needs Fixing
- Martin Pool: Approve
-
Diff: 124 lines (+50/-3)5 files modifiedNEWS (+4/-0)
bzrlib/bzrdir.py (+0/-2)
bzrlib/tests/blackbox/test_upgrade.py (+14/-0)
bzrlib/tests/features.py (+26/-0)
bzrlib/transport/__init__.py (+6/-1)
lp:~mbp/bzr/2.0-262450-backup-permissions
Merged
into
lp:bzr/2.0
- John A Meinel: Approve
-
Diff: 141 lines (+56/-7)6 files modifiedNEWS (+4/-0)
bzrlib/bzrdir.py (+0/-2)
bzrlib/tests/__init__.py (+24/-0)
bzrlib/tests/blackbox/test_upgrade.py (+14/-1)
bzrlib/transport/__init__.py (+5/-1)
doc/developers/testing.txt (+9/-3)
Changed in bzr: | |
assignee: | nobody → Parth Malwankar (parthm) |
status: | Triaged → In Progress |
Changed in bzr: | |
milestone: | none → 2.2b1 |
status: | In Progress → Fix Released |
To post a comment you must log in.
I agree it should inherit the .bzr/ permissions. It isn't hard to do, I'm sure we just didn't think about it.