speed of bzr merge with uncommited changes

Bug #254449 reported by ChriS
4
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Wishlist
Unassigned

Bug Description

bzr merge rightly refuses to work when the branch has uncommited changes. However, before giving that message, it does access the network! It would be better speedwise to first check whether the branch has uncommited changes and only then access the remote branch.

John A Meinel (jameinel)
Changed in bzr:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
tebeka (miki-tebeka) wrote :

Second that, I find it highly annoying as well.

Revision history for this message
Berto (bertosmailbox) wrote :

It's happened to me way too many times that after a good amount of time a merge fails because I have uncommitted changes. bzr should definitely check the local state first.

Revision history for this message
Berto (bertosmailbox) wrote :

I'm not sure if this is the best way to do it, but I've put together a patch that checks for uncommitted changes before doing much other work in the merge command:

http://bazaar.launchpad.net/~bertosmailbox/bzr/bzr/revision/4038

This branch is located at:

lp:~bertosmailbox/bzr/bzr

Any comments are welcome, thanks!

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote : Re: [Bug 254449] Re: speed of bzr merge with uncommited changes

Berto wrote:
> I'm not sure if this is the best way to do it, but I've put together a
> patch that checks for uncommitted changes before doing much other work
> in the merge command:
>
> http://bazaar.launchpad.net/~bertosmailbox/bzr/bzr/revision/4038
>
> This branch is located at:
>
> lp:~bertosmailbox/bzr/bzr
>
> Any comments are welcome, thanks!
>
Cool! Can you please submit this as a merge directive so we can track
it in Bundle Buggy? It's as simply as ...

  bzr send -o ../check-uncommitted-before-merge.patch
  attach that file to an email send to the list with a subject of [MERGE] ...

Ian C.

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.