Invalid regular expression crashes log output
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Low
|
Martin Pool |
Bug Description
When doing a log command with an invalid regular expression passed in bzr crashes.
For example...
bzr log --message=*
outputs...
-------
Traceback (most recent call last):
File "/usr/lib/
return run_bzr(argv)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
result = func(*args, **kwargs)
File "/usr/lib/
limit=limit)
File "/usr/lib/
start_revision, end_revision, search, limit)
File "/usr/lib/
if not searchRE.
File "/usr/lib/
self.
File "/usr/lib/
**self.
File "/usr/lib/
return _real_re_
File "/usr/lib/
return _compile(pattern, flags)
File "/usr/lib/
raise error, v # invalid expression
error: nothing to repeat
bzr 1.3.1 on python 2.5.2.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'log', '--message=*']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
launchpad /usr/lib/
xmloutput /home/will/
*** Bazaar has encountered an internal error.
Please report a bug at https:/
including this traceback, and a description of what you
were doing when the error occurred.
-------
I think bazaar should handle this better. Possibly just outputting nothing.
I agree. I think we should print some error message though (just a one-liner) to avoid user confusion.