bzr missing gives confusing 'up to date' message
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Low
|
Unassigned |
Bug Description
Using current bzr.dev, 'bzr missing --this OTHER-REPO' says "This branch is up to date", when it should say "This branch has no new revisions".
To repeat:
cd /tmp
mkdir a
cd a
bzr init
bzr branch . ../b
echo foo > a_file.txt
bzr add a_file.txt
bzr commit -m 'change'
bzr missing --other ../b
cd ../b
bzr missing --this ../a
bzr missing
Output, and suggestions for correct wording:
$ mkdir a
$ cd a
$ bzr init
$ bzr branch . ../b
Branched 0 revision(s).
$ echo foo > a_file.txt
$ bzr add a_file.txt
added a_file.txt
$ bzr commit -m 'change'
Committing to: /tmp/other-bug/a/
added a_file.txt
Committed revision 1.
$ bzr missing --other ../b
Other branch is up to date.
### Oops, actually *this* branch is up-to-date, but the other branch
### is missing a revision.
### Suggested wording: "This branch is up to date." Or, "Other branch
### has no new revisions."
$ cd ../b
$ bzr missing --this ../a
This branch is up to date.
### Oops, actually this branch is missing a revision, it's the *other*
### branch which is up-to-date.
### Suggested wording: "Other branch is up to date." Or, "This branch
### has no new revisions."
$ bzr missing
Using last location: /tmp/other-bug/a/
You are missing 1 revision(s):
-------
revno: 1
committer: Carl Committer <email address hidden>
branch nick: a
timestamp: Sun 2008-07-20 11:15:12 -0600
message:
change
### Yes, this is correct. It would be more professional to
### say "This branch is missing" instead of "You are missing".
$ bzr version
Bazaar (bzr) 1.6b4
from bzr checkout /home/ccomm/
revision: 3565
revid: <email address hidden>
branch nick: bzr.dev
Python interpreter: /usr/bin/python 2.5.2
Python standard library: /usr/lib/python2.5
bzrlib: /home/ccomm/
Bazaar configuration: /home/ccomm/.bazaar
Bazaar log file: /home/ccomm/
Related branches
- Martin Pool: Approve
- Andrew Bennetts: Needs Fixing
-
Diff: 68 lines (+8/-8)2 files modifiedbzrlib/builtins.py (+2/-2)
bzrlib/tests/blackbox/test_missing.py (+6/-6)
Changed in bzr: | |
status: | Confirmed → In Progress |
tags: | added: check-for-breezy |
Changed in bzr: | |
status: | Confirmed → Fix Released |
tags: | removed: check-for-breezy |
Hi,
Thanks for reporting these problems, I agree.
Thanks,
James