status output goes to to_file instead of logger

[Daniel Fischer]

Some methods send status output to to_file, instead of the logger. This is usually only noticeable when embedding bzrlib. I think this is wrong at least in those cases where a file to write to can't be specified when using the command line client, e.g. "No revisions to pull" when running "bzr pull". Here are some more locations where I believe output should go to the logger instead of to_file:

add.py: self._to_file.write('added %s\n' % _quote(path.raw_path))
add.py: self._to_file.write('added %s w/ file id from %s\n'
branch.py: to_file.write('Conflicting tags:\n')
branch.py: to_file.write(' %s\n' % (name, ))
branch.py: to_file.write('No revisions to pull.\n')
branch.py: to_file.write('Now on revision %d.\n' % self.new_revno)
branch.py: to_file.write('No new revisions to push.\n')
branch.py: to_file.write('Pushed up to revision %d.\n' % self.new_revno)

[James Westby (james-w)]

Hi,

It seems like these things should be note()d instead.

This patch is relevant here:

  http://bundlebuggy.aaronbentley.com/request/<email address hidden>

Thanks,

James