Comment 4 for bug 240550
Revision history for this message
| John A Meinel (jameinel) wrote Re: bzrlib.win32utils.get_home_location incorrect | #4 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
I agree that friendly apps should probably not be populating My Documents. To date, it has been a file we have requested from users, and that makes it difficult to use APPDATA. AIUI, the default behavior is to have all APPDATA directories hidden to users. Which makes it hard for them to find the file to include it in bug reports.
Otherwise, I would say that the best location would actually be in the config directory. ~/.bzr.log is a bit of a hang-over, and I think ~/.bazaar/log would be better. On win32, that would be $APPDATA/
Also, .bzr.log should probably not be in the roaming profile. It can grow to a couple megabytes (before we roll it over to .old and start a new log file). Though if a single process writes 100MB the file can grow without bound. (We only roll it on first access.)
If we do end up putting it somewhere that is hard to reach, we probably should provide a command for grabbing it for the user (which also needs to be careful, as running a bzr command might just roll the log file and hide everything that we want them to send.)