bzr can't parse username containing @ from a url

[seyacat]

in my hosting (Hostgator) i have this user configuration for ftp

user:<email address hidden>
host:www.host.com

when i use this command:
bzr push ftp://<email address hidden>@www.host.com/

bzr identify user like user
and <email address hidden> like host

obiusly i have connection error.

im using bzr on Ubuntu 8.04 Hardy Heron
TY and bye

[John A Meinel (jameinel)]

The official way to supply a url with an @ in it is to URL escape it with %40.

So your address would be:

bzr push ftp://user%<email address hidden>/

Now, if we wanted, we could change our code from:

user, host = netsplit.split('@', 1)
to something like
user, host = netsplit.rsplit('@', 1)

which would presume that host names will never have @, and only the last @ is a separating character.

[Martin Pool (mbp)]

On Fri, May 9, 2008 at 2:32 AM, John A Meinel <email address hidden> wrote:
> The official way to supply a url with an @ in it is to URL escape it
> with %40.

I wonder, if you do that, does it get unescaped before being sent as a username?

> So your address would be:
>
> bzr push ftp://user%<email address hidden>/
>
> Now, if we wanted, we could change our code from:
>
> user, host = netsplit.split('@', 1)
> to something like
> user, host = netsplit.rsplit('@', 1)
>
> which would presume that host names will never have @, and only the last
> @ is a separating character.

I think that would be good. We know it can't be in hostnames and can
be in usernames.

--
Martin <http://launchpad.net/~mbp/>

[Neil Martinsen-Burrell (nmb)]

I've submitted a fix for this to the mailing list.