Bzr ftp support does not handle 250 response from Windows 2003 server for mkdir
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Martin Pool | ||
Python |
Fix Released
|
Unknown
|
Bug Description
Bellow is the stacktrace. I wonder if it is treating the response message from the remore folder as exceptions cause the message indicates success .
Environment:
Windows 2003 Server (the location where the command was run but I belive www.onlinefilef
Dell Inspiron 530 Duol-core processor
Bazaar (bzr) 1.3.1
C:\Depot\
bzr: ERROR: ftplib.error_reply: 250 Create folder operation successful.
Traceback (most recent call last):
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "ftplib.pyc", line 521, in mkd
File "ftplib.pyc", line 619, in parse257
error_reply: 250 Create folder operation successful.
bzr 1.3.1 on python 2.5.2.final.0 (win32)
arguments: ['bzr', 'push', 'ftp://www.
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
launchpad C:\Program Files\Bazaar\
*** Bazaar has encountered an internal error.
Please report a bug at https:/
including this traceback, and a description of what you
were doing when the error occurred.
C:\Depot\
Related branches
- John A Meinel: Approve
- Martin Packman (community): Approve
-
Diff: 36 lines (+14/-1)2 files modifiedNEWS (+3/-0)
bzrlib/transport/ftp/__init__.py (+11/-1)
Changed in bzr: | |
status: | Triaged → Confirmed |
tags: | added: easy ftp win32 |
Changed in bzr: | |
status: | Confirmed → In Progress |
assignee: | nobody → Martin Pool (mbp) |
Changed in python: | |
status: | Unknown → New |
Changed in python: | |
status: | New → Fix Released |
Changed in bzr: | |
milestone: | none → 2.2.0 |
status: | In Progress → Fix Released |
It seems that the server is *supposed* to return a response code of 257, not 250.
250 Requested file action okay, completed.
257 "PATHNAME" created.
According to: www.altools. com/image/ support/ alftp/ALFTP_ 35_help/ FTP_response_ codes_rfc_ 959_messages. htm
http://
We probably could trap and specifically allow 250. Otherwise it should be considered a bug in the Python standard library ftplib ftp processing.