editor paths containing spaces are not parsed correctly

[Tom X. Tobin]

In bzr's commit message editor support, editor paths containing spaces are incorrectly parsed; there is no way to work around this (e.g., by escaping spaces with backslashes).

This behavior is due to bzrlib.msgeditor._run_editor() performing a naive .split(' ') rather than correctly parsing the editor path.

(Discovered in bzr 1.4rc2)

[John A Meinel (jameinel)]

Seems like we could use "shlex.split()" or something else that would let you quote the path with spaces.

We need to *allow* for arguments, because sometimes you have to run the editor with flags. (For example, you need to run 'gvim -f' so that it doesn't disconnect from the calling process, so we know when you are finished editing.)

[Tom X. Tobin (tomxtobin)]

shlex is likely the wrong solution; it's quite old (introduced in 1.5.2) and doesn't understand Unicode. If I knew what should be supported (e.g., backslash escapes of spaces, quotation mark quoting), I'd be happy to whip something up.

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tom Tobin wrote:
> shlex is likely the wrong solution; it's quite old (introduced in 1.5.2)
> and doesn't understand Unicode.

Yes, but we've already worked around that. See
bzrlib.commands.shlex_split_unicode

Consistency is a virtue, so we should use the same mechanism for
splitting commandlines everywhere we can.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIDgE40F+nu1YWqI0RAiWWAJ4j/2U+UHiJhsA/RmlFIihZ/MJtwgCfRd0g
7mKqjzwZeGjV5R+fC70nE1g=
=to1M
-----END PGP SIGNATURE-----

[Tom X. Tobin (tomxtobin)]

Argh! You developers and your time machines! :-)

You're absolutely right regarding consistency; if no one beats me to it, I'll try to come up with a fix using shlex_split_unicode.

[Tomasz Magulski (magul)]

Hi,

I have a question, what can we do with this bug for now, because I have check actual code and the function, that the Aaron Bentley have written, is deprecated from version 2.2?