Cannot push if login is an e-mail address

Bug #215059 reported by Darko Romanov on 2008-04-10
20
Affects Status Importance Assigned to Milestone
Bazaar
High
Neil Martinsen-Burrell
Nominated for 1.6 by Matt Nordhoff
bzr (Debian)
Fix Released
Unknown

Bug Description

If I try to execute the following command:

bzr push --create-prefix ftp://<email address hidden>@my.host

I get:

bzr: ERROR: Unable to connect to <email address hidden>; (-2, 'Name or service not known')

and I can't find the way to escape the first "@", nor I can choose another login, as my hosting gives only that kind of logins.

Darko Romanov

Martin Albisetti (beuno) wrote :

Thanks for submitting this :)

Changed in bzr:
status: New → Triaged
John A Meinel (jameinel) wrote :

Can you try a %40 as the escape code for the @ symbol?

We do:

            user, host = netloc.split('@', 1)
            if ':' in user:
                user, password = user.split(':', 1)
                password = urllib.unquote(password)
            user = urllib.unquote(user)

So you should be able to do:

my%<email address hidden>

James Westby (james-w) on 2008-06-17
Changed in bzr:
importance: Undecided → High
James Westby (james-w) wrote :

Hi,

Encoding the @ was confirmed to work on the Debian bug report,
so that is a reasonable workaround.

I think it would still be better to split on the rightmost @, rather than
the leftmost (is that rsplit rather than split?)

Thanks,

James

Changed in bzr:
status: Unknown → Confirmed
Aaron Bentley (abentley) wrote :

It's not really a workaround; it's doing it correctly. If we can support @ in usernames, great. But using @ instead of %40 is non-standard.

Matt Nordhoff (mnordhoff) wrote :

Fix was merged in bzr.dev r3506.

Changed in bzr:
status: Triaged → Fix Committed
Changed in bzr:
status: Fix Committed → Fix Released
John A Meinel (jameinel) wrote :

This was fixed in bzr 1.6, but that milestone is no longer available. So I'm just marking the oldest thing available.

Changed in bzr:
milestone: none → 1.8
assignee: nobody → nmb
Changed in bzr (Debian):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.