no way to edit subject when using bzr send builtin editor

[Robert Collins]

On Tue, 2008-04-01 at 15:18 +1300, Amos Jeffries wrote:
> I'm getting annoyed by bzr's method of handling "bzr send" emails.
>
> As you may have noticed it adds the subject of the last commit to the
> email. regardless of the message thats asked for manually during the send
> process.
>
> It would be good if bzr pulled its email subject from that new message. We
> are going to be sick of feature submissions going up as "Merged from
> trunk" because the last the thing the developer did was properly check the
> branch was up-to-date.

I think this is a good suggestion. Its a little complex because most
email clients want a subject given when starting the new email, and you
can edit the subject *and* the message at that point. Are you perhaps
supplying a fully prepared message to bzr send? If so then we should
special case that.

 affects bzr

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Robert Collins (lifeless)]

On Tue, 2008-04-01 at 15:41 +1300, Amos Jeffries wrote:

> No. I'm just using:
> bzr send --mailto=squid-dev.squid-cache.org
>
> and entering the message when it asks for one.

Is it popping up a gui client, or a text editor? Does it have a field
for setting a subject?

-Rob

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Amos Jeffries (yadi)]

> On Tue, 2008-04-01 at 15:41 +1300, Amos Jeffries wrote:
>
>
>> No. I'm just using:
>> bzr send --mailto=squid-dev.squid-cache.org
>>
>> and entering the message when it asks for one.
>
> Is it popping up a gui client, or a text editor? Does it have a field
> for setting a subject?

Just a text editor (nano is my system default).

With an empty area for the message followed by a line of '----' then the
list of altered files etc.

Amos

[Martin Pool (mbp)]

So the actual bug is that when bzr runs an editor itself (rather than
passing off to a mail client) there is no way to edit the subject?

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Public bug reported:
>
>> As you may have noticed it adds the subject of the last commit to the
>> email. regardless of the message thats asked for manually during the send
>> process.

send provides a -m parameter to specify a message. That sets the subject.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH8jdK0F+nu1YWqI0RAoMIAJ43C8f7osCO+jgfwA0jwHLUlHufuQCfQT0F
ouAV07a+NWNP1frOf6zXJ3c=
=ssn+
-----END PGP SIGNATURE-----

[Robert Collins (lifeless)]

On Tue, 2008-04-01 at 06:00 +0000, Martin Pool wrote:
> So the actual bug is that when bzr runs an editor itself (rather than
> passing off to a mail client) there is no way to edit the subject?

I think so.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Amos Jeffries (yadi)]

Martin:
  Yes, exactly. local text-editor seems to be behaving differently to -m or -F.

Aaron:
 when -m is used it sets the entire Subject+message. Not too helpful when you have a 2-3 paragraph of specially formatted text needed for other interlinked systems usage. The format first line is Subject, which in theory should play nicely with bzr.
  I've resorted to -F now which seems to work as I think auto-editor should.

(sorry for the late reply, launchpad seems to play badly with my email protections)