Fix deploy host for in-service patch

[Lindley Werner Soares Vieira]

'software deploy host <in-service-patch-release>' should NOT fail if there is no restart-script (post-deploy script) specified in metadata of in-service patch release

sysadmin@controller-0 sample_patches(keystone_admin)]$ cat /etc/build.info

SW_VERSION="24.03"

BUILD_TARGET="Host Installer"

BUILD_TYPE="Formal"

BUILD_ID="2024-03-01_19-00-09"

SRC_BUILD_ID="1823"

JOB="wrcp-master-debian"

BUILD_BY="jenkins"

BUILD_NUMBER="671"

BUILD_HOST="yow-wrcp-lx.wrs.com"

BUILD_DATE="2024-03-02 00:00:09 +0000"

[sysadmin@controller-0 sample_patches(keystone_admin)]$

source /etc/platform/openrc

[sysadmin@controller-0 ~(keystone_admin)]$ sudo software list

Password:

     Release RR State

================= == ========

starlingx-24.03.0 Y deployed

[sysadmin@controller-0 ~(keystone_admin)]$ cd sample_patches/

[sysadmin@controller-0 sample_patches(keystone_admin)]$ ls -l

total 24

rw-rr- 1 sysadmin sys_protected 8549 Mar 4 16:44 starlingx-24.03.1.patch

rw-rr- 1 sysadmin sys_protected 8474 Mar 4 16:44 starlingx-24.03.2.patch

[sysadmin@controller-0 sample_patches(keystone_admin)]$

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software upload starlingx-24.03.1.patch

starlingx-24.03.1 is now uploaded

     Uploaded File Id

======================= =================

starlingx-24.03.1.patch starlingx-24.03.1

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software list

     Release RR State

================= == =========

starlingx-24.03.0 Y deployed

starlingx-24.03.1 N available

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software show starlingx-24.03.1 --packages

starlingx-24.03.1:

    Version: 24.03.1

    State: available

    Status: DEV

    Unremovable: N

    RR: N

    Summary: sample patch test

    Description: In Service patch

    Install Instructions:

                    Sample instructions

    Warnings: Sample warning

    Requires:

                    starlingx-24.03.0

    Contents:

    Packages:

                    logmgmt_1.0-1.stx.7_all.deb

[sysadmin@controller-0 sample_patches(keystone_admin)]$ apt list logmmt

Listing... Done

[sysadmin@controller-0 sample_patches(keystone_admin)]$ apt list logmgmt

Listing... Done

logmgmt/now 1.0-1.stx.6 all [installed,local]

[sysadmin@controller-0 sample_patches(keystone_admin)]$

[sysadmin@controller-0 sample_patches(keystone_admin)]$

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software deploy start starlingx-24.03.1

starlingx-24.03.0 is already being deployed

starlingx-24.03.1 is now in the repo

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software list

     Release RR State

================= == ===============

starlingx-24.03.0 Y deployed

starlingx-24.03.1 N deploying-start

[sysadmin@controller-0 sample_patches(keystone_admin)]$ apt list logmgmt

Listing... Done

logmgmt/now 1.0-1.stx.6 all [installed,local]

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software show

usage: software show [-h] [--packages] release [release ...]

software show: error: the following arguments are required: release

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software deploy show

No deploy in progress.

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software deploy host controller-0

...

Installation failed. Please check logs for details.

[sysadmin@controller-0 sample_patches(keystone_admin)]$

[sysadmin@controller-0 sample_patches(keystone_admin)]$ tail -n 100 /var/log/software.log

2024-03-04T16:36:46.388: software: Config is not yet applied. Skipping init software

2024-03-04T16:36:46.419: software-controller: Creating repo.

2024-03-04T16:36:53.449: software-controller: Creating /opt/software/synced

2024-03-04T16:36:53.792: software-controller: ping -c 1 -w 1 controller

ping: controller: Name or service not known

ping6: controller: Name or service not known

2024-03-04T16:36:53.805: software-controller: Cannot ping controller. Nothing to do

2024-03-04T16:36:55: software-agent[1783]: software_agent.py(99): ERROR: Failed to connect to controller

2024-03-04T16:36:55: software-agent[1783]: software_agent.py(430): INFO: Failed install_uuid check. Skipping query

2024-03-04T16:36:55: software-controller-daemon[1784]: software_controller.py(3287): INFO: launching

2024-03-04T17:35:12.731: software: Config is not yet applied. Skipping init software

2024-03-04T17:35:13.001: software-controller: ping -c 1 -w 1 controller

ping: connect: Network is unreachable

ping6: controller: Address family for hostname not supported

2024-03-04T17:35:13.219: software-controller: Cannot ping controller. Nothing to do

2024-03-04T17:35:25: software-agent[1351]: software_agent.py(99): ERROR: Failed to connect to controller

2024-03-04T17:35:25: software-agent[1351]: software_agent.py(430): INFO: Failed install_uuid check. Skipping query

2024-03-04T17:35:26: software-controller-daemon[1349]: software_controller.py(854): INFO: patch_op_counter is: 1

2024-03-04T17:35:26: software-controller-daemon[1349]: software_controller.py(3287): INFO: launching

2024-03-04T17:35:52: software-controller-daemon[5323]: software_controller.py(854): INFO: patch_op_counter is: 1

2024-03-04T17:35:52: software-controller-daemon[5323]: software_controller.py(3287): INFO: launching

2024-03-04T17:37:59: software-agent[5309]: software_agent.py(277): INFO: Handling detailed query

2024-03-04T17:38:56: software-controller-daemon[5323]: utils.py(222): INFO: Created directory /scratch/upload_files with free space 15852511232 bytes

2024-03-04T17:38:56: software-controller-daemon[5323]: software_functions.py(686): INFO: Signature verified, patch has been signed

2024-03-04T17:38:56: software-controller-daemon[5323]: software_functions.py(686): INFO: Signature verified, patch has been signed

2024-03-04T17:38:56: software-controller-daemon[5323]: apt_utils.py(26): INFO: Uploading package: /scratch/deployment_1saic3uh/logmgmt_1.0-1.stx.7_all.deb

2024-03-04T17:38:58: software-controller-daemon[5323]: software_controller.py(316): INFO: sending sync req

2024-03-04T17:38:58: software-controller-daemon[5323]: software_controller.py(1756): INFO: Sync complete

2024-03-04T17:38:58: software-agent[5309]: software_agent.py(277): INFO: Handling detailed query

2024-03-04T17:40:14: software-controller-daemon[5323]: utils.py(298): INFO: Authenticating for service type: platform, region name: RegionOne, interface: public

2024-03-04T17:40:15: software-controller-daemon[5323]: software_functions.py(1186): INFO: Collect current load for hosts successfully.

2024-03-04T17:40:15: software-controller-daemon[5323]: software_controller.py(2322): INFO: Deploy start order for apply operation: starlingx-24.03.0,starlingx-24.03.1

2024-03-04T17:40:15: software-controller-daemon[5323]: software_controller.py(2345): INFO: Starting deployment for: starlingx-24.03.0

2024-03-04T17:40:15: software-controller-daemon[5323]: software_controller.py(2357): INFO: starlingx-24.03.0 is already being deployed

2024-03-04T17:40:15: software-controller-daemon[5323]: software_controller.py(2345): INFO: Starting deployment for: starlingx-24.03.1

2024-03-04T17:40:15: software-controller-daemon[5323]: software_controller.py(2367): INFO: Latest commit: 95139a5067a1756cd188612a14890682d835bcb5c8747b24601bcb6fabbbc542

2024-03-04T17:40:15: software-controller-daemon[5323]: apt_utils.py(78): INFO: Running apt-ostree install

2024-03-04T17:52:18: software-controller-daemon[5323]: software_controller.py(316): INFO: sending sync req

2024-03-04T17:52:18: software-controller-daemon[5323]: software_controller.py(1756): INFO: Sync complete

2024-03-04T17:52:18: software-agent[5309]: software_agent.py(455): INFO: Active Sysroot Commit:95139a5067a1756cd188612a14890682d835bcb5c8747b24601bcb6fabbbc542 does not match active controller's Feed Repo Commit: 73a0508755efe721b04bd8015b48b880e0754cd806f5c27f65d8beab32eeb0d5

2024-03-04T17:52:18: software-agent[5309]: software_agent.py(455): INFO: Active Sysroot Commit:95139a5067a1756cd188612a14890682d835bcb5c8747b24601bcb6fabbbc542 does not match active controller's Feed Repo Commit: 73a0508755efe721b04bd8015b48b880e0754cd806f5c27f65d8beab32eeb0d5

2024-03-04T17:52:18: software-agent[5309]: software_agent.py(455): INFO: Active Sysroot Commit:95139a5067a1756cd188612a14890682d835bcb5c8747b24601bcb6fabbbc542 does not match active controller's Feed Repo Commit: 73a0508755efe721b04bd8015b48b880e0754cd806f5c27f65d8beab32eeb0d5

2024-03-04T17:52:18: software-controller-daemon[5323]: software_controller.py(169): INFO: Agent controller-0 (192.168.204.2) reporting out_of_date=True, requires_reboot=False

2024-03-04T17:52:18: software-agent[5309]: software_agent.py(277): INFO: Handling detailed query

2024-03-04T17:53:46: software-controller-daemon[5323]: software_controller.py(2653): INFO: Running software deploy host for controller-0 (192.168.204.2), force=False, async_req=True

2024-03-04T17:53:46: software-controller-daemon[5323]: software_controller.py(2657): INFO: Allowing in-service patching

2024-03-04T17:53:46: software-controller-daemon[5323]: software_controller.py(526): INFO: sending install request to node: 192.168.204.2

2024-03-04T17:53:46: software-controller-daemon[5323]: software_controller.py(2678): INFO: host-install async_req: Host installation request sent to controller-0.

2024-03-04T17:53:46: software-agent[5309]: software_agent.py(322): INFO: Handling host install request, force=True

2024-03-04T17:53:46: software-agent[5309]: software_agent.py(331): INFO: Installing on unlocked node, with force option

2024-03-04T17:53:46: software-agent[5309]: software_agent.py(478): INFO: Handling install

2024-03-04T17:53:46: software-agent[5309]: software_agent.py(455): INFO: Active Sysroot Commit:95139a5067a1756cd188612a14890682d835bcb5c8747b24601bcb6fabbbc542 does not match active controller's Feed Repo Commit: 73a0508755efe721b04bd8015b48b880e0754cd806f5c27f65d8beab32eeb0d5

2024-03-04T17:54:06: software-agent[5309]: software_agent.py(564): INFO: Mounting the new deployment

2024-03-04T17:54:06: software-agent[5309]: software_agent.py(571): INFO: Running in-service patch-scripts

2024-03-04T17:54:06: software-agent[5309]: software_agent.py(579): ERROR: In-Service patch installation failed

Traceback (most recent call last):

  File "/usr/lib/python3/dist-packages/software/software_agent.py", line 572, in handle_install

    pull_restart_scripts_from_controller()

  File "/usr/lib/python3/dist-packages/software/software_agent.py", line 75, in pull_restart_scripts_from_controller

    output = subprocess.check_output(["rsync",

  File "/usr/lib/python3.9/subprocess.py", line 424, in check_output

    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,

  File "/usr/lib/python3.9/subprocess.py", line 528, in run

    raise CalledProcessError(retcode, process.args,

subprocess.CalledProcessError: Command '['rsync', '-acv', '--delete', '--exclude', 'tmp', 'rsync://controller/repo/software-scripts/', '/run/software/software-scripts/']' returned non-zero exit status 23.

2024-03-04T17:54:06: software-agent[5309]: software_agent.py(580): ERROR: Command output: b'receiving incremental file list\nrsync: [sender] change_dir "/software-scripts" (in repo) failed: No such file or directory (2)\n\nsent 17 bytes received 107 bytes 248.00 bytes/sec\ntotal size is 0 speedup is 0.00\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1819) [Receiver=3.2.3]\nrsync: [Receiver] read error: Connection reset by peer (104)\n'

2024-03-04T17:54:06: software-controller-daemon[5323]: software_controller.py(169): INFO: Agent controller-0 (192.168.204.2) reporting out_of_date=False, requires_reboot=True

2024-03-04T17:54:06: software-controller-daemon[5323]: software_controller.py(550): INFO: Handling install resp from 192.168.204.2

2024-03-04T17:54:06: software-agent[5309]: software_agent.py(277): INFO: Handling detailed query

2024-03-04T17:54:06: software-agent[5309]: software_agent.py(277): INFO: Handling detailed query

[sysadmin@controller-0 sample_patches(keystone_admin)]$

[sysadmin@controller-0 sample_patches(keystone_admin)]$ date

Mon Mar 4 17:55:35 UTC 2024

[sysadmin@controller-0 sample_patches(keystone_admin)]$ sudo software list

     Release RR State

================= == ==============

starlingx-24.03.0 Y deployed

starlingx-24.03.1 N deploying-host

[sysadmin@controller-0 sample_patches(keystone_admin)]$

[Jelmer Vernooij (jelmer)]

This appears to be unrelated to bzr.