'bzr update' probes the master branch >=3 times

Bug #202613 reported by John A Meinel
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned
Breezy
Triaged
Medium
Unassigned

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The current bzr update code probes for the master branch several times
(which includes probing for the repository format, etc.)

The locations are:

 cmd_update.run()
   Here it opens the master branch to check if the last_revision is the
   same as local, and thus 'nothing to do'.
   If they differ, it then calls WT.update() passing in possible
   transports (so we won't reconnect, but be *will* re-probe for the
   master branch.)

 WT.update()
   uses a "if self.branch.get_master_branch() is not None", which
   requires probing to grab the remote branch, and then throwing it away
   right away.
   We might consider switching to self.branch.get_bound_location(),
   which doesn't have to actually open the master branch.

 Branch.update()
   Opens the master branch and finally does something useful with it
   (pull)

 affects /products/bzr
 importance medium
 status triaged

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH29ZsJdeBCYSNAAMRAsNmAJwP/OFjKaIxSBrvzMRDu7XbJ6m3/gCgxct6
na5lq2FF400dqUsXwsJALa0=
=j2Fz
-----END PGP SIGNATURE-----

Martin Pool (mbp)
Changed in bzr:
status: Triaged → Confirmed
Jelmer Vernooij (jelmer)
tags: added: performance update
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
Changed in brz:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.