TooManyConcurrentRequests error during push

[Henrique]

bzr: ERROR: bzrlib.errors.TooManyConcurrentRequests: The medium '<bzrlib.smart.medium.SmartSSHClientMedium object at 0x107f750>' has reached its concurrent request limit. Be sure to finish_writing and finish_reading on the currently open request.

Traceback (most recent call last):
  File "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line 806, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line 762, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib64/python2.5/site-packages/bzrlib/commands.py", line 492, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib64/python2.5/site-packages/bzrlib/builtins.py", line 824, in run
    push_result = br_from.push(br_to, overwrite)
  File "/usr/lib64/python2.5/site-packages/bzrlib/decorators.py", line 127, in read_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib64/python2.5/site-packages/bzrlib/branch.py", line 1576, in push
    target.unlock()
  File "/usr/lib64/python2.5/site-packages/bzrlib/remote.py", line 1174, in unlock
    self._unlock(branch_token, repo_token)
  File "/usr/lib64/python2.5/site-packages/bzrlib/remote.py", line 1140, in _unlock
    repo_token or '')
  File "/usr/lib64/python2.5/site-packages/bzrlib/smart/client.py", line 33, in call
    result, protocol = self.call_expecting_body(method, *args)
  File "/usr/lib64/python2.5/site-packages/bzrlib/smart/client.py", line 45, in call_expecting_body
    request = self.get_smart_medium().get_request()
  File "/usr/lib64/python2.5/site-packages/bzrlib/smart/medium.py", line 411, in get_request
    return SmartClientStreamMediumRequest(self)
  File "/usr/lib64/python2.5/site-packages/bzrlib/smart/medium.py", line 579, in __init__
    raise errors.TooManyConcurrentRequests(self._medium)
TooManyConcurrentRequests: The medium '<bzrlib.smart.medium.SmartSSHClientMedium object at 0x107f750>' has reached its concurrent request limit. Be sure to finish_writing and finish_reading on the currently open request.

bzr 1.1.0 on python 2.5.1.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'push']
encoding: 'ANSI_X3.4-1968', fsenc: 'ANSI_X3.4-1968', lang: None
plugins:
  launchpad /usr/lib64/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  multiparent /usr/lib64/python2.5/site-packages/bzrlib/plugins/multiparent.pyc [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

[Martin Pool (mbp)]

Thank you for the report, Henrique.

I suspect this occurred because of a transient network problem - the connection dropped, and Bazaar handled the error badly. Do you think that's correct? Is this reproducible?

[Andrew Bennetts (spiv)]

It might be good to arrange for the error message in these cases to include the name of the previously issued request. I seems likely that a bug in the error handling of one request would lead to the next request (in this case, an unlock) failing, with no clue to point to the offending request that failed to handle an error cleanly.

That said, I expect the new version of the network protocol that is planned will help avoid these errors (by making it easier for the protocol implementation to know if a request is still outstanding or not).

[Henrique (weinzh)]

I thought also that my connection dropped. I didn't try to reproduce the error, because the upload destination will be locked after interrupting "bzr push" and until now I don't know how to unlock.