AttributeError: 'NoneType' object has no attribute 'abort'

Bug #184898 reported by Luis Lavena
This bug report is a duplicate of:  Bug #187330: Commit failed with attribute error. Edit Remove
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

I started with a new project and was adding files and the committing 3 or 2 on each commit.

At commit #9, bzr commit command failed with the attached backtrace.

After that, doing a selective commit (each file individual) the revisions bumped 1 but bzr log don't report the missing revision:

bzr check:
checked branch file:///D:/Users/Luis/projects/oss/timetrax/trunk/ format Bazaar
Branch Format 6 (bzr 0.15)
checked repository <bzrlib.transport.local.LocalTransport url=file:///D:/Users/Luis/projects/oss/timetrax/> format <RepositoryFormatKnitPack1>
    12 revisions
    27 file-ids
    22 unique file texts
    73 repeated file texts
     0 unreferenced text versions

bzr log --short --limit 3:
   11 Luis Lavena 2008-01-19
      Some silly specs to kickin rspec into codebase

   10 Luis Lavena 2008-01-19
      Added simple spec_helper

    9 Luis Lavena 2008-01-19
      Added first stab at config/environment
      TimeTrax module needs love.

backtrace:

bzr arguments: [u'commit', u'-m', u'Some silly specs to kickin rspec into codebase']
looking for plugins in D:/Users/Luis/.config/bazaar/2.0/plugins
looking for plugins in C:\Python25\lib\site-packages\bzrlib\plugins
Plugin name __init__ already loaded
Plugin name __init__ already loaded
encoding stdout as sys.stdout encoding 'cp437'
opening working tree 'D:/Users/Luis/projects/oss/timetrax/trunk'
preparing to commit
[ 248] 2008-01-19 22:35:27.921 INFO: Committing to: D:/Users/Luis/projects/oss/timetrax/trunk/
Selecting files for commit with filter None
[ 248] 2008-01-19 22:35:27.921 INFO: added spec/lib
[ 248] 2008-01-19 22:35:27.921 INFO: added spec/spec_helper.rb
[ 248] 2008-01-19 22:35:27.921 INFO: added spec/lib/time_trax_spec.rb
added revision_id {<email address hidden>}
Auto-packing repository <bzrlib.repofmt.pack_repo.RepositoryPackCollection object at 0x0126C5B0>, which has 2 pack files, containing 10 revisions into 1 packs.
Traceback (most recent call last):
  File "C:\Python25\Lib\site-packages\bzrlib\commands.py", line 806, in run_bzr_catch_errors
    return run_bzr(argv)
  File "C:\Python25\Lib\site-packages\bzrlib\commands.py", line 762, in run_bzr
    ret = run(*run_argv)
  File "C:\Python25\Lib\site-packages\bzrlib\commands.py", line 492, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "C:\Python25\Lib\site-packages\bzrlib\builtins.py", line 2328, in run
    author=author)
  File "C:\Python25\Lib\site-packages\bzrlib\decorators.py", line 167, in write_locked
    self.unlock()
  File "C:\Python25\Lib\site-packages\bzrlib\workingtree_4.py", line 1134, in unlock
    self.branch.unlock()
  File "C:\Python25\Lib\site-packages\bzrlib\branch.py", line 1366, in unlock
    self.repository.unlock()
  File "C:\Python25\Lib\site-packages\bzrlib\repofmt\pack_repo.py", line 2005, in unlock
    self.abort_write_group()
  File "C:\Python25\Lib\site-packages\bzrlib\repository.py", line 482, in abort_write_group
    self._abort_write_group()
  File "C:\Python25\Lib\site-packages\bzrlib\repofmt\pack_repo.py", line 1847, in _abort_write_group
    self._pack_collection._abort_write_group()
  File "C:\Python25\Lib\site-packages\bzrlib\repofmt\pack_repo.py", line 1651, in _abort_write_group
    self._new_pack.abort()
AttributeError: 'NoneType' object has no attribute 'abort'

return code 4

This is my bazaar version:

Bazaar (bzr) 1.1.0
  Python interpreter: C:\Python25\python.exe 2.5.1.final.0
  Python standard library: C:\Python25\lib
  bzrlib: C:\Python25\lib\site-packages\bzrlib
  Bazaar configuration: D:\Users\Luis\.config\bazaar\2.0
  Bazaar log file: D:\Users\Luis\Documents\.bzr.log

and the plugins I've installed:

C:\Python25\lib\site-packages\bzrlib\plugins\gtk [0.93.0]
        Graphical support for Bazaar using GTK.
C:\Python25\lib\site-packages\bzrlib\plugins\multiparent.pyc [unknown]
        Implementation of multiparent diffs for versionedfile-like storage
C:\Python25\lib\site-packages\bzrlib\plugins\launchpad [unknown]
        Launchpad.net integration plugin for Bazaar.
C:\Python25\lib\site-packages\bzrlib\plugins\bzrtools [1.1.0]
        Various useful plugins for working with bzr.

Revision history for this message
James Westby (james-w) wrote :

Hi,

I have just submitted a patch to fix this to the list.

Thanks,

James

Changed in bzr:
assignee: nobody → james-w
importance: Undecided → Medium
milestone: none → 1.2
status: New → Fix Committed
Revision history for this message
James Westby (james-w) wrote :

Hi,

The patch I sent is not actually applicable to this issue.

This issue was fixed in revision 3169, and was released
in 1.1.

You report that you are using 1.1, so I'm not sure how you
hit this bug.

Is it possible that you are reporting the version of an
executable that is different from the one that you are
running for the command?

Thanks,

James

James Westby (james-w)
Changed in bzr:
assignee: james-w → nobody
milestone: 1.2 → none
status: Fix Committed → Incomplete
Revision history for this message
Luis Lavena (luislavena) wrote :

Thank you James for your answer.

Actually no, the only bzr executable I've installed is the one I listed.

I tried replicate the situation and it seems the presence (or absence) of GTK plugin make this error disappear.

I'll try again to replicate it without the gtk plugin installed and reopen this ticket.

In any case, could be a issue of bzr-gtk and not bzr itself.

Thanks again for your time,

Luis

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 184898] Re: AttributeError: 'NoneType' object has no attribute 'abort'

On Thu, 2008-01-24 at 15:44 +0000, Luis Lavena wrote:
> Thank you James for your answer.
>
> Actually no, the only bzr executable I've installed is the one I listed.
>
> I tried replicate the situation and it seems the presence (or absence)
> of GTK plugin make this error disappear.
>
> I'll try again to replicate it without the gtk plugin installed and
> reopen this ticket.
>
> In any case, could be a issue of bzr-gtk and not bzr itself.

That's interesting, thanks for investigating.

I would be interested in this issue whether or not it has anything
to do with bzr-gtk installed.

Can you tell me how you installed bzr-gtk please?

Thanks,

James

Revision history for this message
Luis Lavena (luislavena) wrote :

James,

bzr-gtk (0.93.0) was installed downloading the .tar.gz file from this [1] URL and running "python setup.py install" on the extracted files.

[1] http://bazaar-vcs.org/bzr-gtk

I'll try to create a new repo this weekend and try this again and attach the whole .bzr.log file instead, so I'll not miss anything this time.

Again, thank you for your time.

Regards,
--
Luis

Revision history for this message
James Westby (james-w) wrote :

This is indeed still the original bug. There was a problem with the
release of 1.1. My apologies for not checking this better.

Thanks,

James

Changed in bzr:
status: Incomplete → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.