bzr log FILE don't show revisions where file was removed

[Alexander Belchenko]

bzr 1.1rc1. I removed file in some revision, later I decided to resurrect it. And noticed that fact of removing file is not shown in log. It's a bug for me.

Steps to reproduce:

C:\Temp\2>bzr init
C:\Temp\2>echo foo > bar
C:\Temp\2>bzr add
added bar
C:\Temp\2>bzr ci -m 1
Committing to: C:/Temp/2/
added bar
Committed revision 1.
C:\Temp\2>echo spam > bar
C:\Temp\2>bzr ci -m 2
Committing to: C:/Temp/2/
modified bar
Committed revision 2.
C:\Temp\2>bzr rm bar
deleted bar
C:\Temp\2>bzr ci -m 3
Committing to: C:/Temp/2/
deleted bar
Committed revision 3.
C:\Temp\2>bzr log bar
bzr: ERROR: Path does not have any revision history: bar

C:\Temp\2>bzr branch . 3 -r-2
Branched 2 revision(s).
C:\Temp\2>echo boo > bar
C:\Temp\2>bzr add bar --file-ids-from 3
added bar w/ file id from bar
C:\Temp\2>bzr ci -m 4
Committing to: C:/Temp/2/
added bar
Committed revision 4.

C:\Temp\2>bzr log bar -v
------------------------------------------------------------
revno: 4
committer: Alexander Belchenko <email address hidden>
branch nick: 2
timestamp: Wed 2008-01-09 17:09:06 +0200
message:
  4
added:
  bar
------------------------------------------------------------
revno: 2
committer: Alexander Belchenko <email address hidden>
branch nick: 2
timestamp: Wed 2008-01-09 17:04:40 +0200
message:
  2
modified:
  bar
------------------------------------------------------------
revno: 1
committer: Alexander Belchenko <email address hidden>
branch nick: 2
timestamp: Wed 2008-01-09 17:04:27 +0200
message:
  1
added:
  bar

C:\Temp\2>bzr log -v
------------------------------------------------------------
revno: 4
committer: Alexander Belchenko <email address hidden>
branch nick: 2
timestamp: Wed 2008-01-09 17:09:06 +0200
message:
  4
added:
  bar
------------------------------------------------------------
revno: 3
committer: Alexander Belchenko <email address hidden>
branch nick: 2
timestamp: Wed 2008-01-09 17:04:59 +0200
message:
  3
removed:
  bar
------------------------------------------------------------
revno: 2
committer: Alexander Belchenko <email address hidden>
branch nick: 2
timestamp: Wed 2008-01-09 17:04:40 +0200
message:
  2
modified:
  bar
------------------------------------------------------------
revno: 1
committer: Alexander Belchenko <email address hidden>
branch nick: 2
timestamp: Wed 2008-01-09 17:04:27 +0200
message:
  1
added:
  bar

[Robert Collins (lifeless)]

On Wed, 2008-01-09 at 15:13 +0000, Alexander Belchenko wrote:
> Public bug reported:
>
> bzr 1.1rc1. I removed file in some revision, later I decided to
> resurrect it. And noticed that fact of removing file is not shown in
> log. It's a bug for me.

I agree. log -v uses the per file graph to perform the decision of what
to report, and that graph doesn't include terminal markers.

How to fix:

Existing formats:
 - change log -v to spider out inventory deltas looking for the fileid
and using the last-changed field in the parents of a revision it is
present in to skip over unrelated history

New formats:
 - we should record in the perfile graph deletes as an action
 - reconcile can be changed to add this into existing graphs with no
change to the inventory
 - we might want to consider listing deleted paths from parents in the
inventory representation itself, but I'm not sure that that is needed.

-Rob

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Jelmer Vernooij (jelmer)]

This is fixed in bzr.dev.