uncommit is slow with packs

Bug #172649 reported by Matt Nordhoff on 2007-11-28
2
Affects Status Importance Assigned to Milestone
Bazaar
Medium
John A Meinel

Bug Description

Using Linux, bzr.dev r3043 and operating on a fresh copy of bzr.dev, "bzr uncommit --dry-run --force" takes (in user seconds):

dirstate 0.40
dirstate-tags 0.87
pack-0.92 3.86-3.96

Something doesn't seem right here . . .

Matt Nordhoff (mnordhoff) wrote :
Matt Nordhoff (mnordhoff) wrote :

Aww, my tabs got killed.

dirstate 0.40
dirstate-tags 0.87
pack-0.92 3.86-3.96

Maybe spaces'll fare better.

Matt Nordhoff (mnordhoff) wrote :

Heh, anyway...

John A Meinel (jameinel) wrote :

This is almost definitely related to: bug #172975

Basically, 'bzr uncommit' shows a preview of the revisions that will be removed.
And the general 'log' functionality is slower with packs, because things which access a lot of history are slower.

Changed in bzr:
importance: Undecided → Medium
status: New → Triaged
John A Meinel (jameinel) wrote :

It is also because uncommit is doing "branch.revision_history()" rather than doing a simple iteration to determine the revisions to display.

John A Meinel (jameinel) wrote :

I have a patch which gets rid of all the calls to Branch.revision_history(), allowing us to display the revisions very quickly.

Changed in bzr:
assignee: nobody → jameinel
milestone: none → 1.6
status: Triaged → Fix Committed
John A Meinel (jameinel) on 2008-05-30
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments