knit chunk should contains inside all meta information that index has
Bug #164810 reported by
Alexander Belchenko
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
Medium
|
Unassigned | ||
| Breezy |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Currently knit is a series of gzip files joined together. It's possible to zcat full content or even split it out for original chunks, because gzip format support this.
Unfortunately this gzip chunks missed some meta info that knit indices has: fulltext/line-delta kind, parent revision info etc.
So we can't restore index info from knit. IMO it's wrong. It's a blocker for creating repository repairing tools.
In new pack repo formats bzr should provide all metainfo inside knit chunks, so indices will be derivative part of repo not the essential part. Amount of this info inside gzipped chunk is small enough to worry about repo size or performance.
Related branches
Revision history for this message
| John A Meinel (jameinel) wrote | #1 |
| Changed in bzr: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| Changed in bzr: | |
| status: | Triaged → Confirmed |
| tags: | added: knits |
| tags: | added: check-for-breezy |
| tags: | removed: check-for-breezy |
| Changed in brz: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
To post a comment you must log in.
I agree that this is bad. And I even have a branch around which works on changing that.
However, Pack repositories won't be able to "zcat" anyway. Because the pack format itself has some meta-information inbetween the gzip chunks.
I went ahead and registered the branch, and associated it with this bug.
The mailing list thread is:
[RFC] Store all important data in KnitData.