proxy tests fail with newer versions of pycurl
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Vincent Ladeuil |
Bug Description
All ProxyAuth tests fail with newer versions of pycurl:
=======
ERROR: bzrlib.
-------
Traceback (most recent call last):
testtools.
Traceback (most recent call last):
File "/home/
self.
File "/home/
code, response_file = self._get(relpath, None)
File "/home/
return self._get_
File "/home/
self.
File "/home/
'curl connection error (%s)\non %s' % (e[1], url))
bzrlib.
on http://
This is because PyCURL is more strict about the scheme in proxy URLs now. See https:/
Related branches
- Jelmer Vernooij (community): Approve
-
Diff: 102 lines (+48/-1)3 files modifiedbzrlib/tests/test_http.py (+6/-1)
bzrlib/transport/http/_pycurl.py (+4/-0)
doc/en/release-notes/bzr-2.7.txt (+38/-0)
Changed in bzr: | |
assignee: | nobody → Vincent Ladeuil (vila) |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in bzr: | |
status: | Confirmed → In Progress |
Changed in bzr: | |
milestone: | none → 2.7.1 |
Changed in bzr: | |
status: | In Progress → Fix Released |
This is caused by bzrlib. tests.test_ http setting the 'all_proxy' environment variable to a URL that starts with 'http+pycurl://'... pycurl then just looks in the environment for the proxy variable.
We should sanitize the value of this environment variable before setting it in the environment.