TestCase.run_bzr loads plugins by default

Bug #135022 reported by Jonathan Lange
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Low
Unassigned
Launchpad itself
Invalid
Undecided
Unassigned

Bug Description

run_bzr loads plugins by default. This makes the test run dependent on local developer environment settings. We should disable loading plugins in the test suite.

Revision history for this message
Andrew Bennetts (spiv) wrote :

I think this is arguably also a bug in Bazaar; it makes it unnecessarily difficult for projects other than bzr to make a robust test suite that uses bzrlib.tests.TestCase. It's easy to use for a project to use bzrlib.tests.TestCase without realising this would be an issue.

Changed in bzr:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 135022] Re: TestCase.run_bzr loads plugins by default

I agree it's a bug.

Revision history for this message
Robert Collins (lifeless) wrote :

I think it would be spurious for run_bzr to *not* load plugins by
default, it would be being different for difference sake.

IMO run_bzr should honour --no-plugins for folk writing tests that care
- but the vast bulk of tests should work with plugins loaded or not.

Perhaps the command line should parameterise this though, so with
--no-plugins, run_bzr won't load plugins, otherwise it will.

As a library user the default would then be the same as bzrlib's loading
of plugins - e.g. off.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Jonathan Lange (jml) wrote :

Not actually a bug in Launchpad Bazaar.

Changed in launchpad-bazaar:
status: New → Invalid
Martin Pool (mbp)
Changed in bzr:
status: Triaged → Confirmed
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.