setup.py uses CFLAGS - and builds with warnings

[Robert Collins]

setup.py honours CFLAGS. this is probably a feature.

However, my CFLAGS have -Werror, which makes 'make' in the bzr tree
fail.

We should either not honour CFLAGS, strip -Werror from CFLAGS, or build
without errors.

-Rob
 affects /products/bzr
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Matthew Fuller (fullermd)]

It's definitely a Feature. Not honoring CFLAGS would be a bug.

The simplest solution would be to just unconditionally append a "-Wno-error" to the end of the CFLAGS. That shouldn't have any side effects, and should work with or without -Werror being present.

[Martin Pool (mbp)]

> It's definitely a Feature. Not honoring CFLAGS would be a bug.
>
> The simplest solution would be to just unconditionally append a "-Wno-
> error" to the end of the CFLAGS. That shouldn't have any side effects,
> and should work with or without -Werror being present.

I agree that it seems to be a feature. If you don't want to build
with that option, don't do so.

I don't think we can unconditionally append that flag because we're
not guaranteed to be using gcc.

--
Martin

[Aaron Bentley (abentley)]

The only solution everyone seems happy with is rewriting the code so it doesn't emit warnings. This seems hard, especially given that we use Pyrex as an intermediary. And there's an easy workaround. "Doctor, it hurts when I do this" "So stop doing that!"

There are many projects that build with warnings and honour CFLAGS.