verify-signature crashes on non ascii characters
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Reagan Sanders | ||
bzr (Ubuntu) |
Fix Released
|
Undecided
|
Dimitri John Ledkov | ||
Trusty |
Fix Released
|
Medium
|
Dimitri John Ledkov | ||
Utopic |
Fix Released
|
Undecided
|
Dimitri John Ledkov |
Bug Description
Impact:
Bzr crashes when verifying non-ascii characters in signatures, in verbose mode.
Testcase:
bzr branch lp:~xnox/+junk/test-signatures
cd test-signatures
gpg --import key.asc
bzr verify-signatures -v
Original report:
first : on "bzr verify-signatures -v" i get :
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
return the_callable(*args, **kwargs)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
return self._operation
File "/usr/lib/
self.cleanups, self.func, *args, **kwargs)
File "/usr/lib/
result = func(*args, **kwargs)
File "/usr/lib/
write(
File "/usr/lib/
self.
TypeError: can only concatenate list (not "str") to list
maybe a little more straight-forward; if I do "bzr qlog" then click on a revision, i get :
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
f(*args, **kargs)
File "/usr/lib/
r = f(*args, **kargs)
File "/usr/lib/
revids, self.log_
File "/usr/lib/
pass_
File "/usr/lib/
revisions_
File "/usr/lib/
cached_
File "/usr/lib/
return "valid signature from {0}".format(
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe7' in position 4: ordinal not in range(128)
bzr 2.5.1 on python 2.7.3 (Linux-
Ubuntu-
arguments: ['/usr/bin/bzr', 'qlog']
plugins: bash_completion
explorer[
news_
weave_
encoding: 'utf-8', fsenc: 'UTF-8', lang: 'en_CA.UTF-8'
Sorry, my name hapens to be utf-8 !!!
ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: bzr 2.5.1-0ubuntu2
ProcVersionSign
Uname: Linux 3.2.0-38-generic x86_64
NonfreeKernelMo
ApportVersion: 2.0.1-0ubuntu17.1
Architecture: amd64
CheckboxSubmission: 07acc21e2cd262f
CheckboxSystem: 2a6f54df59af338
Date: Tue Feb 12 15:47:08 2013
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release amd64 (20101007)
MarkForUpload: True
PackageArchitec
ProcEnviron:
TERM=xterm
PATH=(custom, no user)
LANG=en_CA.UTF-8
SHELL=/bin/bash
SourcePackage: bzr
UpgradeStatus: Upgraded to precise on 2012-06-05 (252 days ago)
Related branches
- Reagan Sanders (community): Approve
- Richard Wilbur: Approve
-
Diff: 277 lines (+162/-45)6 files modifiedbzrlib/commit_signature_commands.py (+2/-1)
bzrlib/log.py (+1/-1)
bzrlib/tests/blackbox/__init__.py (+1/-0)
bzrlib/tests/blackbox/test_sign_my_commits.py (+0/-43)
bzrlib/tests/blackbox/test_verify_signatures.py (+124/-0)
bzrlib/tests/test_log.py (+34/-0)
Changed in bzr: | |
assignee: | nobody → Reagan Sanders (vexofp) |
status: | New → In Progress |
Changed in bzr: | |
status: | In Progress → Fix Committed |
milestone: | none → 2.7b1 |
Changed in bzr: | |
status: | Fix Committed → Fix Released |
Changed in bzr: | |
importance: | Undecided → Medium |
Changed in bzr (Ubuntu Trusty): | |
assignee: | nobody → Dimitri John Ledkov (xnox) |
Changed in bzr (Ubuntu Utopic): | |
assignee: | nobody → Dimitri John Ledkov (xnox) |
description: | updated |
Changed in bzr (Ubuntu Trusty): | |
status: | New → In Progress |
importance: | Undecided → Low |
importance: | Low → Medium |
Update : I created a fake key without the "ç".
"verify-signatures -v" still crashes, but qbzr doesn't anymore