"bzr log -m S" causes TypeError in filtering through regex a tuple

Bug #1096121 reported by Chad Miller on 2013-01-04
This bug affects 4 people
Affects Status Importance Assigned to Milestone

Bug Description

d$ bzr log -m demo
bzr: ERROR: exceptions.TypeError: expected string or buffer

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 930, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 1141, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 673, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 697, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 136, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 1158, in ignore_pipe
    result = func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/bzrlib/builtins.py", line 2895, in run
    Logger(b, rqst).show(lf)
  File "/usr/lib/python2.7/dist-packages/bzrlib/log.py", line 382, in show
  File "/usr/lib/python2.7/dist-packages/bzrlib/log.py", line 411, in _show_body
    for lr in generator.iter_log_revisions():
  File "/usr/lib/python2.7/dist-packages/bzrlib/log.py", line 451, in iter_log_revisions
    for revs in revision_iterator:
  File "/usr/lib/python2.7/dist-packages/bzrlib/log.py", line 872, in _filter_re
    new_revs = [rev for rev in revs if _match_filter(searchRE, rev[1])]
  File "/usr/lib/python2.7/dist-packages/bzrlib/log.py", line 886, in _match_filter
    if k in strings and not _match_any_filter(strings[k], v):
  File "/usr/lib/python2.7/dist-packages/bzrlib/log.py", line 891, in _match_any_filter
    return any([filter(None, map(re.search, strings)) for re in res])
TypeError: expected string or buffer

bzr 2.6b2 on python 2.7.3 (Linux-3.5.0-19-generic-i686-with-
arguments: ['/usr/bin/bzr', 'log', '-m', 'demo']
plugins: bash_completion[2.6b2], builddeb[2.7.0dev], bzrtools[2.5.0],
    changelog_merge[2.6b2], dbus[0.1.0dev], difftools[unknown],
    extmerge[unknown], gtk[0.104.0dev], launchpad[2.6b2],
    netrc_credential_store[2.6b2], news_merge[2.6b2], pipeline[1.1.0],
    po_merge[2.6b2], pqm[1.4.0dev], rewrite[0.6.4dev], stats[0.2.0dev],
    svn[1.2.1], weave_fmt[2.6b2]
encoding: 'utf-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'

**** entering debugger
> /usr/lib/python2.7/dist-packages/bzrlib/log.py(891)_match_any_filter()
-> return any([filter(None, map(re.search, strings)) for re in res])

(Pdb) p strings
[u'Micah Gersten <email address hidden>', u'* New upstream release from the Stable Channel (LP: #992352)\n - [106413] High CVE-2011-3078: Use after free in floats handling. Credit to\n Google Chrome Security Team (Marty Barbella) and independent later\n discovery by miaubiz.\n - [117110] High CVE-2012-1521: Use after free in xml parser. Credit to\n Google Chrome Security Team (SkyLined) and independent later discovery by\n wushi of team509 reported through iDefense VCP (V-874rcfpq7z).\n - [117627] Medium CVE-2011-3079: IPC validation failure. Credit to PinkiePie\n - [121726] Medium CVE-2011-3080: Race condition in sandbox IPC. Credit to\n Willem Pinckaers of Matasano.\n - [121899] High CVE-2011-3081: Use after free in floats handling.\n Credit to miaubiz.', (u'https://launchpad.net/bugs/992352', u'fixed'), u'Micah Gersten <email address hidden>']

(Pdb) map(type, strings)
[<type 'unicode'>, <type 'unicode'>, <type 'tuple'>, <type 'unicode'>]


John A Meinel (jameinel) on 2013-01-10
Changed in bzr:
importance: Undecided → High
status: New → Confirmed
Jelmer Vernooij (jelmer) on 2017-11-08
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers