aborted pending locks left behind
Bug #109169 reported by
Martin Pool
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Martin Pool |
Bug Description
Bazaar lockdirs can get pending.* directories left behind if clients are interrupted. The user can just delete them but maybe Bazaar should remove them automatically if they are more than N days old, or on some other reasonable criteria.
Changed in bzr: | |
assignee: | nobody → mbp |
status: | Confirmed → Fix Committed |
Changed in bzr: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
It creates a lot more if the lock is currently held. At present, it tries every 1s to lock the target, and if it is already locked, it will leave a pending lock file.
With the standard timeout of 5m an old lock can generate 300 pending.* directories.
I think that we could
1) Have a failed attempt cleanup after itself
or
2) Have a failed attempt reuse the 'pending.*' directory. It might re-use the 'info' file, but as that contains a timestamp, we may prefer to update it.