bzr: Unable to sign commits: "no terminal at all requested"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Jelmer Vernooij | ||
bzr (Debian) |
Confirmed
|
Unknown
|
|||
bzr (Ubuntu) |
Fix Released
|
High
|
Jelmer Vernooij | ||
Precise |
Fix Released
|
High
|
Jelmer Vernooij | ||
Quantal |
Fix Released
|
High
|
Jelmer Vernooij |
Bug Description
Imported from Debian bug http://
Without any modification in my configuration, Bzr is now rejecting my
signatures to commits:
$ bzr sign-my-commits
<email address hidden>
gpg: Sorry, no terminal at all requested - can't get input
bzr: ERROR: Failed to GPG sign data with command "[u'gpg', '--clearsign', '-u', <email address hidden>', '--no-tty']"
This bug was introduced in 2.5.1 and later snapshots of bzr 2.6. 2.5.1 was SRU'ed into precise.
[Impact]
This affects users of the 2.5.1 SRU who sign commits on the command-line without a GPG agent. The proposed fix reverts the use of --no-tty which will reintroduce bug 847388, which was also present long before 2.5.1.
[Test Case]
Install bzr and gpg. Make sure there is no active GPG agent ("unset GPG_AGENT_INFO") and try to sign a few commits ("bzr sign-my-commits"). This should succeed, and prompt for a GPG password on the terminal.
[Regression Potential]
This is a revert of a problematic change in a SRU. We'll definitely reintroduce bug 847388, but that is a bug that has been present for a long time and only affects a really limited amount of users.
Related branches
- Martin Packman (community): Approve
-
Diff: 55 lines (+6/-4)3 files modifiedbzrlib/gpg.py (+1/-1)
bzrlib/tests/test_gpg.py (+3/-3)
doc/en/release-notes/bzr-2.5.txt (+2/-0)
Changed in bzr (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
tags: | added: regressionb |
Changed in bzr: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in bzr (Ubuntu): | |
importance: | Medium → High |
Changed in bzr (Debian): | |
importance: | Undecided → Unknown |
Changed in bzr (Debian): | |
status: | New → Confirmed |
tags: |
added: regression removed: regressionb |
tags: | added: regression-update |
Changed in bzr: | |
status: | Triaged → In Progress |
Changed in bzr (Ubuntu Precise): | |
status: | New → In Progress |
importance: | Undecided → High |
Changed in bzr (Ubuntu Quantal): | |
status: | Triaged → In Progress |
Changed in bzr: | |
milestone: | none → 2.6b2 |
Changed in bzr (Ubuntu Precise): | |
milestone: | none → precise-updates |
Changed in bzr (Ubuntu Quantal): | |
milestone: | none → quantal-alpha-3 |
description: | updated |
Changed in bzr: | |
status: | In Progress → Fix Released |
This appears to be a regression from the fix for bug 847388, which is a little odd that seemed to be a well thought out change.