I'll take a look into it, but first I want to have a working version of the
repo manager (hopefully this week).

David
El 30/06/2012 20:15, "Martin Packman" <email address hidden>
escribió:

> That's great David. If you can work out a good place to insert a check
> in the bzrlib code that raises a better error that would be a good
> change too.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1008223
>
> Title:
>   Error when pushing through smart server
>
> Status in Bazaar Version Control System:
>   Invalid
>
> Bug description:
>   I'm trying to develop a little repo manager like gitosis for git. And
>   when doing the first push from the client to the server, this error
>   shows up:
>
>   bzr: ERROR: bzrlib.errors.ErrorFromSmartServer: Error received from
>   smart server: ('error', "invalid literal for int() with base 10:
>   'None'")
>
>   Traceback (most recent call last):
>     File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 920,
> in exception_to_return_code
>       return the_callable(*args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 1131,
> in run_bzr
>       ret = run(*run_argv)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 673,
> in run_argv_aliases
>       return self.run(**all_cmd_args)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/commands.py", line 695,
> in run
>       return self._operation.run_simple(*args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 136,
> in run_simple
>       self.cleanups, self.func, *args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166,
> in _do_with_cleanups
>       result = func(*args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/builtins.py", line 1379,
> in run
>       use_existing_dir=use_existing_dir, no_tree=no_tree)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/push.py", line 145, in
> _show_push_branch
>       remember, create_prefix)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/controldir.py", line
> 425, in push_branch
>       overwrite, stop_revision=revision_id)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/branch.py", line 1142,
> in push
>       lossy, *args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/branch.py", line 3507,
> in push
>       _override_hook_source_branch=_override_hook_source_branch)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 132,
> in run
>       self.cleanups, self.func, self, *args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/cleanup.py", line 166,
> in _do_with_cleanups
>       result = func(*args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/branch.py", line 3562,
> in _push_with_bound_branches
>       result = self._basic_push(overwrite, stop_revision)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/branch.py", line 3524,
> in _basic_push
>       graph=graph)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/decorators.py", line
> 218, in write_locked
>       result = unbound(self, *args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/branch.py", line 3425,
> in _update_revisions
>       self.fetch(stop_revision=stop_revision)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/decorators.py", line
> 218, in write_locked
>       result = unbound(self, *args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/branch.py", line 3402,
> in fetch
>       fetch_spec=fetch_spec)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/remote.py", line 2157,
> in fetch
>       find_ghosts=find_ghosts, fetch_spec=fetch_spec)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/decorators.py", line
> 218, in write_locked
>       result = unbound(self, *args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/vf_repository.py", line
> 2584, in fetch
>       find_ghosts=find_ghosts)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/fetch.py", line 77, in
> __init__
>       self.__fetch()
>     File "/usr/lib/python2.7/dist-packages/bzrlib/fetch.py", line 104, in
> __fetch
>       self._fetch_everything_for_search(search_result)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/fetch.py", line 132, in
> _fetch_everything_for_search
>       stream, from_format, [])
>     File "/usr/lib/python2.7/dist-packages/bzrlib/remote.py", line 2881,
> in insert_stream
>       (verb, path, resume_tokens) + lock_args, byte_stream)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/client.py", line
> 108, in call_with_body_stream
>       expect_response_body=False)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/client.py", line
> 55, in _call_and_read_response
>       return request.call_and_read_response()
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/client.py", line
> 157, in call_and_read_response
>       return self._call(protocol_version)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/client.py", line
> 192, in _call
>       expect_body=self.expect_response_body)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/message.py", line
> 308, in read_response_tuple
>       _raise_smart_server_error(self.args)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/message.py", line
> 353, in _raise_smart_server_error
>       raise errors.ErrorFromSmartServer(error_tuple)
>   ErrorFromSmartServer: Error received from smart server: ('error',
> "invalid literal for int() with base 10: 'None'")
>
>
>   On the server side I also get this error:
>   dom 2012-06-03 22:22:26 +0200
>   0.033  bazaar version: 2.3.4
>   0.033  bzr arguments: [u'serve', u'--inet',
> u'--directory=/home/bzr/repositories/bazitis-cascara@prometeus',
> u'--allow-writes']
>   0.047  looking for plugins in /home/bzr/.bazaar/plugins
>   0.083  looking for plugins in
> /usr/lib/python2.7/dist-packages/bzrlib/plugins
>   0.096  encoding stdout as osutils.get_user_encoding() 'UTF-8'
>   0.575  Traceback (most recent call last):
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/request.py", line
> 356, in _call_converting_errors
>       return callable(*args, **kwargs)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/request.py", line
> 141, in execute
>       return self.do(*args)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/branch.py", line
> 52, in do
>       return self.do_with_branch(branch, *args)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/smart/branch.py", line
> 171, in do_with_branch
>       revno, last_revision = branch.last_revision_info()
>     File "/usr/lib/python2.7/dist-packages/bzrlib/decorators.py", line
> 138, in read_locked
>       self.lock_read()
>     File "/usr/lib/python2.7/dist-packages/bzrlib/branch.py", line 2502,
> in lock_read
>       self.repository.lock_read()
>     File "/usr/lib/python2.7/dist-packages/bzrlib/repofmt/pack_repo.py",
> line 2404, in lock_read
>       self._refresh_data()
>     File "/usr/lib/python2.7/dist-packages/bzrlib/repofmt/pack_repo.py",
> line 2328, in _refresh_data
>       self._pack_collection.reload_pack_names()
>     File "/usr/lib/python2.7/dist-packages/bzrlib/repofmt/pack_repo.py",
> line 2036, in reload_pack_names
>       first_read = self.ensure_loaded()
>     File "/usr/lib/python2.7/dist-packages/bzrlib/repofmt/pack_repo.py",
> line 1667, in ensure_loaded
>       self._names[name] = self._parse_index_sizes(value)
>     File "/usr/lib/python2.7/dist-packages/bzrlib/repofmt/pack_repo.py",
> line 1679, in _parse_index_sizes
>       return tuple([int(digits) for digits in value.split(' ')])
>   ValueError: invalid literal for int() with base 10: 'None'
>
>
>   I found that changing this line on the bzrlib/repofmt/pack_repo.py file
> on the client and the server:
>   1100         return tuple([int(digits) for digits in value.split(' ')])
>
>   to this:
>   1100         return tuple([int(digits) for digits in
> value.replace('None', '0').split(' ')])
>
>   Solves the problem and the I can work with the repositories. But I'm
>   not sure if this may introduce more errors or if it is safe.
>
>   Thanks
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/bzr/+bug/1008223/+subscriptions
>