Bazaar XML output plugin

XML-RPC service broken by bzr-2.1

Reported by Adrian Wilkins on 2010-02-23
68
This bug affects 12 people
Affects Status Importance Assigned to Milestone
Bazaar Windows Installers
Critical
Bazaar Windows Team
bzr-xmloutput
High
Unassigned
bzr-xmloutput (Debian)
Fix Released
Unknown
bzr-xmloutput (Ubuntu)
High
Andrew Starr-Bochicchio

Bug Description

Upgrading to bzr 2.1.0 breaks many of the features of bzr-java-lib when using the XmlRpcClient.

2.0.4

tests happy for both CommandLine and XmlRpcClient

2.1.0

CommandLine

testSearch() fails - but this test always uses XmlRpcClient regardless of preference.

XmlRpcClient produces 9 errors and 13 failures. All these failures appear to be due to the library not receiving any output via STDOUT.

Looks like the problem is to do with the code regarding streaming output.

Bisection reveals three thresholds at which the error profile changes :

1 x SilentUIFactory doesn't support make_output_stream (in testVersionInfo())

On revision 4792.8.4 (<email address hidden>):
Convert version-info to use TextUIOutputStream

3 x SilentUIFactory doesn't support make_output_stream (breaking most tests)

On revision 4792.8.9 (<email address hidden>):
Send Command.outf through UIFactory

9 errors and 13 failures start here (masks previous problems to an extent)

On revision 4797.170.1 (<email address hidden>):
SilentUIFactory now accepts make_output_stream and discards what is written

adrian@motoko:~/bzr/bzr-2.0.4$ bzr version
Bazaar (bzr) 2.1.0
  Python interpreter: /usr/bin/python 2.6.4
  Python standard library: /usr/lib/python2.6
  Platform: Linux-2.6.31-19-generic-x86_64-with-Ubuntu-9.10-karmic
  bzrlib: /usr/lib/python2.6/dist-packages/bzrlib

Changed in bzr-xmloutput:
status: New → Confirmed
importance: Undecided → High
Changed in bzr-xmloutput:
status: Confirmed → Fix Committed
milestone: none → 0.8.7
Adrian Wilkins (adrian-wilkins) wrote :

Those affected by this bug can grab the latest trunk revision.

e.g.

 cd ~/.bazaar/plugins
 rm -rf xmloutput
 bzr branch lp:bzr-xmloutput xmloutput

Kyle Schweighauser (kms) wrote :

Just now tested and it worked for me.

Using the steps I described in bug #537808.

Thanks,

Kyle

PS my only difference is I keep my plugins @ /usr/share/pyshared/bzrlib/plugins

Changed in bzr-xmloutput (Ubuntu):
status: New → Confirmed
importance: Undecided → High
milestone: none → ubuntu-10.04-beta-2
Olivier Berger (olivierberger) wrote :

I can confirm this seems to fix it too for me (applying this patch :http://bazaar.launchpad.net/%7Eadrian-wilkins/bzr-xmloutput/dont-use-silent-ui.526740/diff/144)

Changed in bzr-xmloutput (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr-xmloutput - 0.8.6-1ubuntu1

---------------
bzr-xmloutput (0.8.6-1ubuntu1) lucid; urgency=low

  * Backport dont-use-silent-ui.patch from upstream
    bzr branch. Fixes XML-RPC service with bzr 2.1
    (LP: #526740).
 -- Andrew Starr-Bochicchio <email address hidden> Fri, 02 Apr 2010 15:12:16 -0400

Changed in bzr-xmloutput (Ubuntu):
status: In Progress → Fix Released
Changed in bzr-xmloutput (Debian):
status: Unknown → Confirmed
Changed in bzr-xmloutput (Debian):
status: Confirmed → Fix Released
Changed in bzr-windows-installers:
status: New → Confirmed
assignee: nobody → Bazaar Windows Team (bzr-windows)
Adrian Wilkins (adrian-wilkins) wrote :

Just a small prod - the bundled version of bzr-xmloutput in the Windows distribution still suffers from this bug, so a default install doesn't work with bzr-eclipse. Just had to manually install a newer version of bzr-xmloutput on a colleagues machine - doesn't make for the perfect "evangelism" experience.

Alexander Belchenko (bialix) wrote :

Thanks for the heads up. We should update the version in installer config to 0.8.7 for both 2.2.x and 2.3.x series.

Changed in bzr-windows-installers:
importance: Undecided → Critical
Changed in bzr-xmloutput:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.