Encoding problems in xmloutput and redstone xmlrpc

Bug #388300 reported by Display Name
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Bazaar Plugin for Eclipse
Fix Released
Undecided
Guillermo Gonzalez
Eclipse
Invalid
Undecided
Unassigned
Java library for Bazaar
Fix Released
Undecided
Guillermo Gonzalez
bzr-xmloutput
Fix Released
High
Unassigned

Bug Description

Encoding problems:
    xmloutput: non-ascii URLs and ascii decoding of non-ascii strings.
    redstone xmlrpc: actual XML data encoding not matching the one declared in XML preamble.

---------------------------------------------------------------------------
Original description:

I had this issue: https://answers.launchpad.net/bzr/+question/74455. Then I deleted Bazaar\plugins\xmloutput, and installed version 0.8.4 using the installer. Then I reinstalled the bzr-eclipse plugin, but when I try to do anything I get errors. I successfully did a bzr log --xml though. This error e.g. happens when I try to share the project:

Executing: init Utilidades
    Error while executing init
    <class 'xml.parsers.expat.ExpatError'>:not well-formed (invalid token): line 1, column 330

Tags: bzr eclipse rpc xml
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi Renato,

PLease check that the bzr executable you'r using is the right one, like if it's using the installed xmloutput.

Regards,

Revision history for this message
Guillermo Gonzalez (verterok) wrote : Re: [Bug 388300] Re: Error after installing bzr-xmloutput

Hi Renato

On Thu, Jun 18, 2009 at 1:05 AM, Renato Silva<email address hidden> wrote:
> I think it is the right one because it is the only I have (1.15-1 by
> windows installer). Maybe it is a problem of Eclipse itself? If I could
> at least debug the error, but the message is unclear.

Could you paste the errors?

If you have a Eclipse with the SDK (Classic, Plugin developer,
distributions) you can see the error log opening the "Error log" view:
Windows --> Views --> Error Log
Also you can get the los from <workspace>/.metadata/.log

Regards,

Revision history for this message
Guillermo Gonzalez (verterok) wrote : Re: [Bug 388300] Re: Error after installing bzr-xmloutput

Hi! thanks for the logs,

Looks like xmlstatus command is the one that's broked.

Could you try to run it from command line in the same branch?

Thanks.

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

uh, looks like this is an xmloutput issue, not bzr-eclipse.

Are you using UTF-8 as the encoding your eclipse workspace?

what's the encoding of your fs?

Don't know how to check this on windows..
if you have python installed:
python -c "import sys; print sys.getfilesystemencoding()"

and the terminal encoding?

Please look for "encoding stdout as sys.stdout" in the $HOME/.bzr.log file (or win32 equivalent of $HOME :) )

also, it's bzr status showing the file in the correct encoding?

summary: - Error after installing bzr-xmloutput
+ BzrEclipse does not work with accented paths
Revision history for this message
Guillermo Gonzalez (verterok) wrote : Re: BzrEclipse does not work with accented paths

looks like is a mismatch between bzr-eclipse and xmloutput, please try changing the workspace encoding to utf-8.

I'm working in a patch to tell xmloutput which encoding to use.

Regards,

tags: added: bzr eclipse rpc xml
Changed in bzr-xmloutput:
importance: Undecided → High
status: New → Confirmed
summary: - BzrEclipse does not work with accented paths
+ xmlstatus ignores user encoding (always use UTF-8)
Revision history for this message
Guillermo Gonzalez (verterok) wrote : Re: xmlstatus ignores user encoding (always use UTF-8)

After looking the xmlstatus code, I found that the issue is that the encoding specified is always UTF-8, instead of the user encoding.
I pushed a fix to the related branch, I'll work on a unittest for this.

could you test this fix?

Thanks.

Changed in bzr-eclipse:
status: New → Invalid
summary: - xmlstatus ignores user encoding (always use UTF-8)
+ Encoding problems in xmloutput: non-ascii URLs and unchecked string
+ decodings
Changed in eclipse:
status: Unknown → Confirmed
Changed in bzr-java-lib:
status: New → Invalid
Changed in eclipse:
status: Confirmed → Unknown
Changed in eclipse:
status: Unknown → Invalid
Changed in eclipse:
importance: Unknown → Undecided
status: Invalid → New
status: New → Invalid
summary: - Encoding problems in xmloutput: non-ascii URLs and unchecked string
- decodings
+ Encoding problems in xmloutput: non-ascii URLs and ascii decoding of
+ non-ascii strings
Changed in bzr-xmloutput:
assignee: nobody → Renato Silva (renatosilva)
status: Confirmed → Fix Committed
description: updated
Changed in bzr-xmloutput:
status: Fix Committed → Confirmed
Changed in bzr-eclipse:
status: Invalid → Confirmed
Changed in bzr-xmloutput:
status: Confirmed → Fix Committed
Changed in bzr-java-lib:
status: Invalid → Confirmed
summary: - Encoding problems in xmloutput: non-ascii URLs and ascii decoding of
- non-ascii strings
+ Encoding problems in xmloutput (non-ascii URLs and ascii decoding of
+ non-ascii strings) and redstone xmlrpc
summary: - Encoding problems in xmloutput (non-ascii URLs and ascii decoding of
- non-ascii strings) and redstone xmlrpc
+ Encoding problems in xmloutput and redstone xmlrpc
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

A build of redstone xmlrpc-client 1.1.1-r35 is available at verterok.com.ar/maven-repo also bzr-java-lib and bzr-eclipse pom(s) are updated to use this version

Changed in bzr-eclipse:
status: Confirmed → Fix Committed
Changed in bzr-java-lib:
assignee: nobody → Guillermo Gonzalez (verterok)
status: Confirmed → Fix Committed
Changed in bzr-eclipse:
assignee: nobody → Guillermo Gonzalez (verterok)
summary: - Encoding problems in xmloutput and redstone xmlrpc
+ Encoding problems in xmloutput ((non-ascii URLs and ascii decoding of)
+ and redstone xmlrpc (XML preamble and actual data not matching)
description: updated
summary: - Encoding problems in xmloutput ((non-ascii URLs and ascii decoding of)
- and redstone xmlrpc (XML preamble and actual data not matching)
+ Encoding problems in xmloutput and redstone xmlrpc
Changed in bzr-xmloutput:
milestone: none → 0.8.6
Changed in bzr-xmloutput:
status: Fix Committed → Fix Released
Changed in bzr-eclipse:
milestone: none → 1.2
status: Fix Committed → Fix Released
Changed in bzr-java-lib:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.