bzr-svn: svn plugin seems to mess with read-only basic https connection

Bug #774571 reported by Jelmer Vernooij
28
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Bazaar Subversion Plugin
Status tracked in 1.2
1.2
Fix Released
Medium
Jelmer Vernooij
bzr-svn (Debian)
Fix Released
Unknown
bzr-svn (Ubuntu)
Fix Released
Medium
Jelmer Vernooij

Bug Description

Imported from Debian bug http://bugs.debian.org/610397:

Package: bzr-svn
Version: 1.0.3-1
Severity: normal

Hi.

The following fails :
$ bzr checkout https://forge.projet-coclico.org/anonscm/bzr/wp5/oberger/planetforge-cli
bzr: ERROR: Connection closed: Unexpected end of message. Please check connectivity and permissions, and report a bug if problems persist.

Whereas it works fine with:
$ bzr --no-plugins checkout https://forge.projet-coclico.org/anonscm/bzr/wp5/oberger/planetforge-cli

Our analysis of the problem is that bzr-svn plugin may be messing with access to it.

However there doesn't seem to be any way to declare that it's not to be accessed with SVN, but instead with plain Bzr in the URI :-/

The above branch should be accessible to you for more detailed analysis.

Thanks in advance.

Best regards,

-- System Information:
Debian Release: 6.0
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages bzr-svn depends on:
ii bzr 2.1.2-1 easy to use distributed version co
ii python 2.6.6-3+squeeze5 interactive high-level object-orie
ii python-central 0.6.16+nmu1 register and build utility for Pyt
ii python-subvertpy 0.7.3-1 Alternative Python bindings for Su

Versions of packages bzr-svn recommends:
ii python-tdb 1.2.1-2+b1 Python bindings for TDB
ii python-xdg 0.19-2 Python library to access freedeskt

Versions of packages bzr-svn suggests:
ii bzr-rewrite 0.6.0-1 History rewriting plugin for Bazaa

-- debconf-show failed

Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: New → Triaged
Changed in bzr-svn (Ubuntu):
status: New → Triaged
Changed in bzr-svn:
importance: Undecided → Medium
Changed in bzr-svn (Ubuntu):
importance: Undecided → Medium
Changed in bzr-svn (Debian):
importance: Undecided → Unknown
Changed in bzr-svn (Debian):
status: New → Confirmed
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This happens because of a non-404 page not found page.

Changed in bzr-svn:
importance: Medium → Low
Changed in bzr-svn (Ubuntu):
importance: Medium → Low
Jelmer Vernooij (jelmer)
Changed in bzr-svn:
importance: Low → Medium
Changed in bzr-svn (Ubuntu):
importance: Low → Medium
Revision history for this message
Jan Pobrislo (ccx) wrote :
Download full text (4.0 KiB)

This bug seems to persist in versions 1.1.0 and 1.1.1

% bzr branch https://people.samba.org/bzr/jelmer/dulwich/trunk/ dulwich2
bzr: ERROR: Connection closed: Unexpected end of message. Please check connectivity and permissions, and report a bug if problems persist.

% bzr branch https://www.webprojekty.cz/ccx/bzr/zmuch zmuch
bzr: ERROR: Invalid http response for https://www.webprojekty.cz/ccx/bzr/zmuch/.bzr/branch-format: Unable to handle http code 405: expected 200 or 404 for full response.:

both sites respond with proper 404 on file not found. Here is snippet from webserver logs:

213.29.225.26 - - [26/Oct/2011:12:57:05 +0200] "OPTIONS /ccx/bzr/zmuch/ HTTP/1.1" 405 354 "-" "bzr/2.4.1 (pycurl: libcurl/7.22.0 GnuTLS/2.10.5 zlib/1.2.5.1)" "-"
213.29.225.26 - - [26/Oct/2011:12:57:05 +0200] "OPTIONS /ccx/bzr/zmuch/.bzr/smart HTTP/1.1" 405 354 "-" "bzr/2.4.1 (pycurl: libcurl/7.22.0 GnuTLS/2.10.5 zlib/1.2.5.1)" "-"
213.29.225.26 - - [26/Oct/2011:12:57:06 +0200] "OPTIONS /ccx/bzr/zmuch/.bzr/branch-format HTTP/1.1" 405 354 "-" "bzr/2.4.1 (pycurl: libcurl/7.22.0 GnuTLS/2.10.5 zlib/1.2.5.1)" "-"

405 Method Not Allowed seems like an appropriate response to OPTIONS request to me.

Moreover when you have bzr-svn-1.1.0 and bzr-git it triggers this quite misleading traceback:

bzr: ERROR: exceptions.AttributeError: 'NoneType' object has no attribute '_transport'

Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/bzrlib/commands.py", line 946, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/bzrlib/commands.py", line 1150, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib64/python2.7/site-packages/bzrlib/commands.py", line 699, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib64/python2.7/site-packages/bzrlib/commands.py", line 721, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/bzrlib/cleanup.py", line 135, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/bzrlib/cleanup.py", line 165, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/home/ccx/.bazaar/plugins/externals/commands.py", line 218, in run
    super(cmd_branch, self).run(**kwargs)
  File "/usr/lib64/python2.7/site-packages/bzrlib/builtins.py", line 1263, in run
    from_location)
  File "/usr/lib64/python2.7/site-packages/bzrlib/bzrdir.py", line 919, in open_tree_or_branch
    return bzrdir._get_tree_branch()
  File "/usr/lib64/python2.7/site-packages/bzrlib/controldir.py", line 410, in _get_tree_branch
    branch = self.open_branch(name=name)
  File "/home/ccx/.bazaar/plugins/git/dir.py", line 368, in open_branch
    repo = self.open_repository()
  File "/home/ccx/.bazaar/plugins/git/dir.py", line 407, in open_repository
    return self._gitrepository_class(self)
  File "/home/ccx/.bazaar/plugins/git/repository.py", line 238, in __init__
    GitRepository.__init__(self, gitdir)
  File "/home/ccx/.bazaar/plugins/git/repository.py", line 118, in __init__
    gitdir, None)
  File "/usr/lib64/python2.7/site-packages/bzrlib/repository.py", line 375, in __i...

Read more...

Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: Triaged → Fix Committed
Changed in bzr-svn (Ubuntu):
status: Triaged → In Progress
Changed in bzr-svn:
assignee: nobody → Jelmer Vernooij (jelmer)
milestone: none → 1.2.0
Changed in bzr-svn (Ubuntu):
assignee: nobody → Jelmer Vernooij (jelmer)
Changed in bzr-svn (Debian):
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr-svn - 1.2.0-1

---------------
bzr-svn (1.2.0-1) unstable; urgency=low

  * Fix format for copyright file.
  * New upstream release.
   + Fixes "tainting" of pycurl HTTPS connections. Closes: #610397,
     LP: #774571
   + Fixes compatibility with newer prereleases of bzr 2.5. Closes: #656864

 -- Jelmer Vernooij <email address hidden> Mon, 23 Jan 2012 14:46:33 +0100

Changed in bzr-svn (Ubuntu):
status: In Progress → Fix Released
Jelmer Vernooij (jelmer)
no longer affects: bzr-svn/1.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.