launchpad plugin package branch checking breaks bzr-svn ("TypeError: expected string or buffer")

Bug #814713 reported by Max Bowsher on 2011-07-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Git Plugin
High
Jelmer Vernooij
Bazaar Subversion Plugin
High
Jelmer Vernooij

Bug Description

The recent addition of code to check package branch freshness breaks any bzr operation in a Subversion working copy (using bzr-svn).

For example, running "bzr st" :

bzr: ERROR: exceptions.TypeError: expected string or buffer

Traceback (most recent call last):
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/commands.py", line 918, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/commands.py", line 1118, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.7/dist-packages/bzrlib/plugins/loom/commands.py", line 203, in run_argv_aliases
    self._original_command().run_argv_aliases(argv, alias_argv)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/commands.py", line 676, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/commands.py", line 698, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/cleanup.py", line 135, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/cleanup.py", line 165, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/commands.py", line 1133, in ignore_pipe
    result = func(*args, **kwargs)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/builtins.py", line 294, in run
    tree, relfile_list = WorkingTree.open_containing_paths(file_list)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/workingtree.py", line 325, in open_containing_paths
    tree = WorkingTree.open_containing(default_directory)[0]
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/workingtree.py", line 309, in open_containing
    return control.open_workingtree(), relpath
  File "/home/maxb/.bazaar/plugins/svn/workingtree.py", line 1269, in open_workingtree
    self.local_path, self.entry)
  File "/home/maxb/.bazaar/plugins/svn/workingtree.py", line 195, in __init__
    self.mapping = self.branch.mapping
  File "/home/maxb/.bazaar/plugins/svn/workingtree.py", line 253, in branch
    self._branch = self.bzrdir.open_branch()
  File "/home/maxb/.bazaar/plugins/svn/workingtree.py", line 1346, in open_branch
    self.get_branch_path(), mapping)
  File "/home/maxb/.bazaar/plugins/svn/branch.py", line 211, in __init__
    super(SvnBranch, self).__init__(mapping)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/foreign.py", line 232, in __init__
    super(ForeignBranch, self).__init__()
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/branch.py", line 109, in __init__
    hook(self)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/plugins/launchpad/__init__.py", line 503, in _check_is_up_to_date
    info = _get_package_branch_info(the_branch.base)
  File "/home/maxb/wc/bzr/bzr/trunk/bzrlib/plugins/launchpad/__init__.py", line 486, in _get_package_branch_info
    m = _package_branch.search(url)
TypeError: expected string or buffer

Jelmer Vernooij (jelmer) wrote :

fixed in trunk (the only version currently compatible with bzr 2.4)

affects: bzr → bzr-svn
Changed in bzr-svn:
assignee: nobody → Jelmer Vernooij (jelmer)
importance: Undecided → Critical
status: New → Fix Released
Changed in bzr-git:
status: New → Fix Released
importance: Undecided → Critical
importance: Critical → High
Changed in bzr-svn:
importance: Critical → High
Changed in bzr-git:
assignee: nobody → Jelmer Vernooij (jelmer)
milestone: none → 0.6.1
Changed in bzr-svn:
milestone: none → 1.1.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers