ec2 land and bzr lp-land should recognize "unreviewed" review types
Bug #669936 reported by
Gavin Panella
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar PQM Plugin |
New
|
Undecided
|
Unassigned | ||
Launchpad itself |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
The "Activities" section in:
https:/
instructs us to self-review by approving merge proposals with the
"unreviewed" type. However, ec2 land does not count these type of
reviews. Upon inspection, neither does bzr lp-land.
For now it is sufficient to self review without a type (agreed with
jml and lifeless). For stats, it is still possible to determine
that a proposal is self-reviewed.
To post a comment you must log in.
Just to be sure, I checked and it's easy to see if a merge proposal is
self-reviewed:
>>> from launchpadlib import launchpad Launchpad. login_with( ...) getByUrl( url='.. .') landing_ targets[ 0] votes[: 2]
>>> root = launchpad.
>>> branch = root.branches.
>>> merge_proposal = branch.
>>> votes = merge_proposal.
>>> self_reviewed = (
... len(votes) == 1 and votes[0].reviewer == branch.owner)