incompatibility with 'bzr shell'

Bug #379049 reported by Martin Häcker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Pager Plugin
Confirmed
Medium
Unassigned

Bug Description

When invoked from within "bzr shell" the exit code of 255 seems to confuse "bzr shell" into aborting.

Which is not usefull.

The included patch fixes that for me.

-- snip --
=== modified file '__init__.py'
--- __init__.py 2009-02-25 07:49:01 +0000
+++ __init__.py 2009-05-21 13:55:37 +0000
@@ -49,7 +49,7 @@

     os.environ['LESS'] = 'FRSX'
     os.execlp(pager, pager)
- sys.exit(255)
+ sys.exit(0)

 def run_in_pager(cmd_class):
-- snap --

Regards,
Martin

Tags: patch
Revision history for this message
Martin Häcker (spamfaenger) wrote :

Well I just noticed that this doesn't completely fix the bug. The Interaction between less and the bzr shell is still not correct. :-/

Also the pager still uses the whole terminal - even though it should display only some lines.

Sorry, but I dunno yet how to fix that.

Regards,
Martin

Jelmer Vernooij (jelmer)
Changed in bzr-pager:
status: New → Confirmed
importance: Undecided → Medium
summary: - incompatibility with bzrtools
+ incompatibility with 'bzr shell'
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.