passes in parent revision ids rather than inventories to CommitBuilder.record_entry_contents
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Loom |
Fix Released
|
High
|
Jelmer Vernooij |
Bug Description
This is triggering test failures with newer versions of bzr:
> =======
> ERROR: bzrlib.
> -------
> _StringException: Text attachment: log
> ------------
> 0.446 creating repository in file://
> 0.449 creating branch <bzrlib.
> 0.456 trying to create missing lock '/tmp/testbzr-
> 0.456 opening working tree '/tmp/testbzr-
> 0.462 opening working tree '/tmp/testbzr-
> 0.466 opening working tree '/tmp/testbzr-
> 0.486 opening working tree '/tmp/testbzr-
> 0.501 creating repository in file://
> 0.504 Using fetch logic to copy between CHKInventoryRep
> 0.504 fetching: <PendingAncestr
> 0.504 creating branch <bzrlib.
> 0.522 created new branch LoomBranch7(
> 0.524 trying to create missing lock '/tmp/testbzr-
> 0.525 opening working tree '/tmp/testbzr-
> 0.544 preparing to commit
> INFO Committing to: /tmp/testbzr-
> 0.549 Selecting files for commit with filter None
> INFO Committed revision 1.
> 0.558 Committed revid <email address hidden> as revno 1.
> 0.564 Base revid: 'null:'
> INFO All changes applied successfully.
> INFO Moved to thread 'top'.
> INFO This thread is now empty, you may wish to run "bzr combine-thread" to remove it.
> 0.576 preparing to commit
> INFO Committing to: /tmp/testbzr-
> 0.579 Selecting files for commit with filter None
> INFO Committed revision 2.
> 0.588 Committed revid <email address hidden> as revno 2.
> INFO All changes applied successfully.
> INFO Moved to thread 'bottom'.
> 0.605 preparing to commit
> INFO Committing to: /tmp/testbzr-
> 0.608 Selecting files for commit with filter None
> INFO Committed revision 2.
> 0.616 Committed revid <email address hidden> as revno 2.
> 0.625 Error suppressed by only_raises:
> 0.625 Traceback (most recent call last):
> File "/usr/lib/
> return unbound(*args, **kwargs)
> File "/usr/lib/
> % self)
> BzrError: Must end write group before releasing write lock on CHKInventoryRep
>
> 0.634 opening working tree '/tmp/testbzr-
> ------------
> Text attachment: traceback
> ------------
> Traceback (most recent call last):
> File "/usr/lib/
> return fn(*args, **kwargs)
> File "/usr/lib/
> return self._get_
> File "/build/
> source.
> File "/usr/lib/
> result = unbound(self, *args, **kwargs)
> File "/build/
> ('file', 0, False, None))
> File "/usr/lib/
> parent_
> File "/usr/lib/
> if inv.has_
> AttributeError: 'str' object has no attribute 'has_id'
> ------------
>
Related branches
- Vincent Ladeuil: Approve
-
Diff: 12 lines (+1/-1)1 file modifiedbranch.py (+1/-1)
Changed in bzr-loom: | |
status: | New → Triaged |
importance: | Undecided → Medium |
importance: | Medium → High |
assignee: | nobody → Jelmer Vernooij (jelmer) |
status: | Triaged → In Progress |
Changed in bzr-loom: | |
status: | In Progress → Fix Committed |
milestone: | none → 2.2 |
Changed in bzr-loom: | |
status: | Fix Committed → Fix Released |