Import/type errors in bzr-handle-patch
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar GTK+ Frontends |
Fix Released
|
High
|
Curtis Hovey | ||
bzr-gtk (Ubuntu) |
Fix Released
|
High
|
Jelmer Vernooij |
Bug Description
There are type errors where the diff.py is making gtk2 pack_start() calls. A cursoary look at bzr-handle-patch reveals that it too is working with gtk2.
$./bzr-handle-patch ../handle-
File "./bzr-
controller = DiffController(
File "/usr/lib/
window = DiffWindow(
File "/usr/lib/
self.
File "/usr/lib/
hbox = self._get_
File "/usr/lib/
hbox.
File "/usr/lib/
return info.invoke(*args, **kwargs)
TypeError: pack_start() takes exactly 5 non-keyword arguments (2 given)
Related branches
- Jelmer Vernooij (community): Approve
-
Diff: 221 lines (+112/-14)4 files modifiedbzr-handle-patch (+7/-4)
diff.py (+14/-10)
tests/test_commit.py (+31/-0)
tests/test_diff.py (+60/-0)
Changed in bzr-gtk: | |
assignee: | nobody → Curtis Hovey (sinzui) |
milestone: | none → 0.104.0 |
status: | New → In Progress |
tags: | added: gtk3 |
Changed in bzr-gtk: | |
status: | In Progress → Fix Committed |
Changed in bzr-gtk (Ubuntu): | |
assignee: | nobody → canonical-bazaar (canonical-bazaar) |
Changed in bzr-gtk: | |
importance: | Undecided → High |
Changed in bzr-gtk (Ubuntu): | |
status: | New → In Progress |
assignee: | canonical-bazaar (canonical-bazaar) → Jelmer Vernooij (jelmer) |
importance: | Undecided → High |
Changed in bzr-gtk: | |
status: | Fix Committed → Fix Released |
This bug was fixed in the package bzr-gtk - 0.103.0+bzr780-1
---------------
bzr-gtk (0.103.0+bzr780-1) unstable; urgency=low
* Use machine-parseable copyright file format.
* Bump standards version to 3.9.3 (no changes).
* Drop suggests of bzr-avahi, which is no longer available. LP:
#926470
* New upstream snapshot.
+ Fixes mixed use of gtk2 and gtk3 in bzr-notify. LP: #903444
+ Prevents crash when the diff widget is being closed. LP: #914363
+ Fixes syntax highlighting using the gedit color scheme. LP: #672158
+ Fixes import/type errors in bzr-handle-patch. LP: #926315
-- Jelmer Vernooij <email address hidden> Wed, 29 Feb 2012 15:04:43 +0100