test suite errors: icon are missing and threads are left running
Bug #840649 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar GTK+ Frontends |
Fix Released
|
High
|
Curtis Hovey | ||
Bug Description
./setup.py check has errors as observed on oneiric. There are two issues that I have fixed in the gtk3 branch that also belong in gtk2.
1. There are reports that the icons cannot be loaded by test_revisionview and test_annotate_
2. The avatars leak lots of threads. The avatars need refactoring to ensure that threads do not block and they join when destroy is called.
Related branches
lp:~sinzui/bzr-gtk/fix-threads-icons
- Jelmer Vernooij (community): Approve
-
Diff: 268 lines (+110/-21)6 files modifiedavatarproviders.py (+29/-16)
avatarsbox.py (+11/-4)
tests/__init__.py (+1/-0)
tests/test_annotate_config.py (+8/-1)
tests/test_avatarsbox.py (+47/-0)
tests/test_revisionview.py (+14/-0)
| Changed in bzr-gtk: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-ok |
| tags: | removed: qa-ok |
| Changed in bzr-gtk: | |
| status: | Fix Committed → Fix Released |
| milestone: | none → 0.103.0 |
To post a comment you must log in.
