bzr uncommit expects a display

[Thomas Vander Stichele]

I was logged in remotely on my laptop.

I ran the following:

[thomas@otto object-views]$ bzr uncommit
   25 Thomas Vander Stichele 2010-11-16 [merge]
      add comment to clarify

The above revision(s) will be removed.
Are you sure [y/N]? y
bzr: ERROR: exceptions.RuntimeError: could not open display

Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/bzrlib/commands.py", line 842, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.6/site-packages/bzrlib/commands.py", line 1037, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.6/site-packages/bzrlib/commands.py", line 654, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.6/site-packages/bzrlib/builtins.py", line 4612, in run
    local=local)
  File "/usr/lib/python2.6/site-packages/bzrlib/builtins.py", line 4669, in _run
    revno=revno, local=local)
  File "/usr/lib/python2.6/site-packages/bzrlib/uncommit.py", line 111, in uncommit
    hook_new_tip)
  File "/usr/lib/python2.6/site-packages/bzrlib/plugins/gtk/__init__.py", line 145, in save_commit_messages
    from bzrlib.plugins.gtk import commit
  File "/usr/lib/python2.6/site-packages/bzrlib/plugins/gtk/commit.py", line 26, in <module>
    import gtk
  File "/usr/lib/python2.6/site-packages/gtk-2.0/gtk/__init__.py", line 64, in <module>
    _init()
  File "/usr/lib/python2.6/site-packages/gtk-2.0/gtk/__init__.py", line 52, in _init
    _gtk.init_check()
RuntimeError: could not open display

bzr 2.0.5 on python 2.6.2 (Linux-2.6.32.21-168.fc12.i686.PAE-i686-with-fedora-12-Constantine)
arguments: ['/usr/bin/bzr', 'uncommit']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  gtk /usr/lib/python2.6/site-packages/bzrlib/plugins/gtk [0.97.0.final]
  launchpad /usr/lib/python2.6/site-packages/bzrlib/plugins/launchpad [2.0.5]
  netrc_credential_store /usr/lib/python2.6/site-packages/bzrlib/plugins/netrc_credential_store [2.0.5]

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    including this traceback and a description of the problem.
[thomas@otto object-views]$

I do not expect bzr to open a gui; if it tries to, it should gracefully fail and proceed to uncommit.

I suggest a unit/integration test suite that gets run without display under something like buildbot to catch this kind of stuff.

[Jelmer Vernooij (jelmer)]

This is not bzr itself, but rather a plugin that hooks into bzr that's causing problems.