move of bzrlib.util.bencode into bzrlib.bencode breaks bzr-gtk

Bug #385212 reported by GuilhemBichot on 2009-06-09
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Jelmer Vernooij

Bug Description

In revision
4410 revid:<email address hidden>
of, moved from bzrlib.util to bzrlib. Thus, code like: bzrlib.util import bencode bzrlib.util.bencode import bdecode
of bzr-gtk breaks. bzr-gtk needs an update, or bzrlib needs a backward compatibility feature...

tags: added: mysql
GuilhemBichot (guilhem-bichot) wrote :

I had to do such fix in our MySQL-internal plugin:
-from bzrlib.util import bencode
+ from bzrlib import bencode
+except ImportError: # bencode was in "util" in the past
+ from bzrlib.util import bencode
because it has to work with pre-rename and post-rename bzr (colleagues may upgrade our plugin without upgrading bzr).
Maybe bzr-gtk needs to do the same?

Jelmer Vernooij (jelmer) on 2009-06-09
Changed in bzr-gtk:
assignee: nobody → Jelmer Vernooij (jelmer)
status: New → Fix Released
GuilhemBichot (guilhem-bichot) wrote :

Hi Jelmer. Probably not a complete fix: after pulling bzr-gtk (revno 644), I still see
./ bzrlib.util.bencode import bdecode
./tests/ bzrlib.util import bencode
./tests/ bzrlib.util import bencode
./tests/ bzrlib.util import bencode
For example "bzr gmissing" fails.

John A Meinel (jameinel) wrote :

I did submit:

which would at least allow backwards compatibility. It will cause DeprecationWarnings in development versions (those are suppressed in release versions).

Of course, ProgressBarStack has been deprecated since 1.12, and bzr-gtk still used it...

Anyway, changing the imports is the 'correct' thing to do, I just thought I'd mention that likely 1.16 will have backwards compatibility anyway.

Changed in bzr:
importance: Undecided → High
milestone: none → 1.16
status: New → Fix Committed
Jonathan Lange (jml) wrote :

Looks like this has landed on trunk already.

Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers