gannotate: dies with AttributeError: 'module' object has no attribute 'validate_bus_name'
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar GTK+ Frontends |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
gannotate from 0.93.0 worked but after upgrading bzr-gtk to the latest branch it fails with:
Traceback (most recent call last):
File "/usr/local/
return run_bzr(argv)
File "/usr/local/
ret = run(*run_argv)
File "/usr/local/
return self.run(
File "/home/
from annotate.gannotate import GAnnotateWindow
File "/home/
from bzrlib.
File "/home/
from bzrlib.plugins.gtk import seahorse
File "/home/
dbus.
AttributeError: 'module' object has no attribute 'validate_bus_name'
bzr 1.3 on python 2.5.0.final.0 (linux2)
The reason is that validate_bus_name requires dbus 0.80 and my dbus is 0.71 (default of opensuse 10.2). Upgrading is not trivial on this machine.
The code does try to survive errors: seahorse.py has:
try:
dbus.
except ValueError:
raise ImportError
and then revisionview.py:
try:
from bzrlib.plugins.gtk import seahorse
except ImportError:
has_seahorse = False
else:
has_seahorse = True
But what I get is not ValueError but AttributeError, so it's not caught... If I change seahorse.py to catch any exception and not just ValueError, gannotate seems to work fine again.
Changed in bzr-gtk: | |
milestone: | none → 0.94.0 |
status: | New → Fix Committed |
Changed in bzr-gtk: | |
status: | Fix Committed → Fix Released |
Latest bzr-gtk has the fix (line 37 rev 480 May 1st). You can close the bug. Thanks!