"bzr commit-notify" should listen for Revision signals from any source

Bug #206443 reported by James Henstridge
2
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Fix Released
Undecided
Unassigned

Bug Description

I've been working on some improvements to bzr-dbus that change the way the "Revision" signals are emitted. With the changes there is no longer any broadcast daemon, and the signals originate from either from the process where the branch change occurred or from the lan-notify process (for network changes).

The attached branch updates the "bzr commit-notify" to watch for "Revision" signals from any source. This makes it work with both existing bzr-dbus and bzr-dbus with my changes.

Revision history for this message
Daniel Schierbeck (dasch) wrote :

This looks nice. I've also been thinking of adding auto-updating to the branch visualization tool, making it respond to commits, pulls, and merges. I think it would nice not having to restart it each time you make a change. I'll see if I can reuse some of your code to accomplish that.

Changed in bzr-gtk:
status: New → Confirmed
Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 206443] [NEW] "bzr commit-notify" should listen for Revision signals from any source

Hi James,

On Di, 2008-03-25 at 09:46 +0000, James Henstridge wrote:
> I've been working on some improvements to bzr-dbus that change the way
> the "Revision" signals are emitted. With the changes there is no longer
> any broadcast daemon, and the signals originate from either from the
> process where the branch change occurred or from the lan-notify process
> (for network changes).
>
> The attached branch updates the "bzr commit-notify" to watch for
> "Revision" signals from any source. This makes it work with both
> existing bzr-dbus and bzr-dbus with my changes.
Thanks! Getting rid of the broadcast daemon is a very useful change. Any
chance you could send a merge request for this to the bzr-gtk mailing
list? (<email address hidden>).

Cheers,

Jelmer

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
James Henstridge (jamesh) wrote :

I've sent a bundle to the list, which is currently sitting in the moderation queue.

Revision history for this message
James Henstridge (jamesh) wrote :

The fix has been merged to lp:bzr-gtk in r462.

Changed in bzr-gtk:
status: Confirmed → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-gtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.