gcommit fails with central bzr smart server

Bug #185869 reported by Daniel Nyström
2
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Triaged
Medium
Unassigned

Bug Description

When doing gcommit in a repo which is a branch from a bzr smart server repo, it fails with the following error dialog:
---
Unknown error
unsupported operand type(s) for /: 'float' and 'NoneType'
---
This appears in a dialog window, and nothing is written in console.

If I mark the "Only commit locally" it works though.

bzr-gtk version is latest from trunk (revno 411) on bzr 1.0.0.

Revision history for this message
Szilveszter Farkas (phanatic) wrote :

Can you commit the same changes from the command line without any errors?

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Please attach a backtrace.

Revision history for this message
Daniel Nyström (speakman) wrote :

No problem committing from command line.

And there is no traceback, only the dialog window. If I can make one, please let me know how.

Revision history for this message
Szilveszter Farkas (phanatic) wrote :

If you don't mind editing some source code, then you should disable generic exception handling in the Commit dialog source: remove the @show_bzr_error decorator from the _on_commit_clicked method in commit.py.

Revision history for this message
Daniel Nyström (speakman) wrote :

So I did, and of course I can't reconstruct the error message. Now it all works.
I've changed my repo a bit since the first report, so the circumstances aren't quite the same though.

The the code is changed, and I'll get back to this report next time I hit the bug.

Revision history for this message
Daniel Nyström (speakman) wrote :

Ok, here it is:

me@computer:~/projects/myproject/trunk$ bzr gcommit
Committing to: bzr://myserver.local/myproject/trunk/
modified Makefile
modified config.h
modified db.c
modified http.c
modified gui/action.c
modified gui/mainpage.c
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/commit.py", line 637, in _on_commit_clicked
    self._do_commit()
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/commit.py", line 680, in _do_commit
    revprops=revprops)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/workingtree_4.py", line 245, in commit
    result = WorkingTree3.commit(self, message, revprops, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 187, in commit
    revprops=revprops, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/commit.py", line 386, in commit
    revision_id=self.rev_id)
  File "/usr/lib/python2.5/site-packages/bzrlib/remote.py", line 674, in fetch
    source, revision_id=revision_id, pb=pb)
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 873, in fetch
    return inter.fetch(revision_id=revision_id, pb=pb, find_ghosts=find_ghosts)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 165, in write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 2558, in fetch
    revision_ids).pack()
  File "/usr/lib/python2.5/site-packages/bzrlib/repofmt/pack_repo.py", line 588, in pack
    return self._create_pack_from_packs()
  File "/usr/lib/python2.5/site-packages/bzrlib/repofmt/pack_repo.py", line 713, in _create_pack_from_packs
    self._copy_revision_texts()
  File "/usr/lib/python2.5/site-packages/bzrlib/repofmt/pack_repo.py", line 612, in _copy_revision_texts
    self.pb.update("Copying revision texts", 1)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/ui.py", line 61, in update
    self.set_fraction(1.0 * current / total)
TypeError: unsupported operand type(s) for /: 'float' and 'NoneType'

In the Commit dialog I've left a one line Commit Message and then pressed "Commit". Thats all.

It all went fine doing "bzr commit" in command line.

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 185869] [NEW] gcommit fails with central bzr smart server

Am Freitag, den 25.01.2008, 10:24 +0000 schrieb speakman:
> Public bug reported:
>
> When doing gcommit in a repo which is a branch from a bzr smart server repo, it fails with the following error dialog:
Looks like a problem in the progress indicators.

  status triaged
  importance medium

Cheers,

Jelmer

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Changed in bzr-gtk:
importance: Undecided → Medium
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.