bzr grep does not handle binary files cleanly

[Parth Malwankar]

[bingrep]% bzr grep parthm bin.file
bzr: ERROR: exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0x84 in position 1: ordinal not in range(128)

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    attaching the crash file
        /home/parthm/.cache/crash/bzr-20100303130926-23727.crash
    and including a description of the problem.

    The crash file is plain text and you can inspect or edit it to remove
    private information.
[bingrep]%

[Parth Malwankar (parthm)]

[bingrep]% bzr grep foo bin.file
Binary file 'bin.file' skipped.
[bingrep]%

[Martin Pool (mbp)]

On 4 March 2010 01:12, Parth Malwankar <email address hidden> wrote:
> [bingrep]% bzr grep foo bin.file
> Binary file 'bin.file' skipped.
> [bingrep]%

That's good if it really is binary. Can it also cope with non-ascii text files?

--
Martin <http://launchpad.net/~mbp/>

[Parth Malwankar (parthm)]

On Mon, Mar 8, 2010 at 1:58 PM, Martin Pool <email address hidden> wrote:
> On 4 March 2010 01:12, Parth Malwankar <email address hidden> wrote:
>> [bingrep]% bzr grep foo bin.file
>> Binary file 'bin.file' skipped.
>> [bingrep]%
>
> That's good if it really is binary.  Can it also cope with non-ascii
> text files?
>
>
> --
> Martin <http://launchpad.net/~mbp/>
>

I am not really a unicode expert so a review would be good. I have already
raised a request for review[1]. For handling this case I am using
bzrlib.textfile.text_file.

    # test and skip binary files
    str_file = cStringIO.StringIO(tree.get_file_text(id))
    try:
        iter_file = textfile.text_file(str_file)
    except errors.BinaryFile, e:
        trace.warning("Binary file '%s' skipped." % path)
        return

    index = 1
    for line in iter_file:
......

[1] https://code.launchpad.net/~parthm/bzr-grep/bzr-grep-1st-full-review/+merge/20634

[Martin Pool (mbp)]

that's pretty good